@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an issue in Harbormaster when a buildable has no repository
Summary: Not every revision belongs to a repository, so we might end up here with `$repo` still equal to `null`. Don't fatal if we do.
Test Plan: iiam
Reviewers: btrahan, hach-que, zeeg
Reviewed By: hach-que
CC: aran
Maniphest Tasks: T1049
Differential Revision: https://secure.phabricator.com/D7771
+6
-3
+6
-3
src/applications/harbormaster/storage/build/HarbormasterBuild.php
+6
-3
src/applications/harbormaster/storage/build/HarbormasterBuild.php
···
183
183
$repo = $object->getRepository();
184
184
}
185
185
186
-
$results['repository.callsign'] = $repo->getCallsign();
187
-
$results['repository.vcs'] = $repo->getVersionControlSystem();
188
-
$results['repository.uri'] = $repo->getPublicRemoteURI();
186
+
if ($repo) {
187
+
$results['repository.callsign'] = $repo->getCallsign();
188
+
$results['repository.vcs'] = $repo->getVersionControlSystem();
189
+
$results['repository.uri'] = $repo->getPublicRemoteURI();
190
+
}
191
+
189
192
$results['step.timestamp'] = time();
190
193
$results['build.id'] = $this->getID();
191
194