recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Check if app is installed for user before displying

Summary: Fixes T11595. Previously if a user didn't have permissions to view an application it would still appear in the application typeahead in various menus. This change will prevent that by checking if the app is installed for the viewer before displaying it as an option

Test Plan: I went to the "Pin Applications" menu and typed in "Conpherence" and saw it appear as an option. I then went to the "Edit Policies" menu as an admin and removed permissions for my user to use Conpherence. Once I did that, it no longer showed up in the typeahead menu

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley, yelirekim

Maniphest Tasks: T11595

Differential Revision: https://secure.phabricator.com/D16518

Josh Cox 0030bda1 25bd14a9

+6
+6
src/applications/meta/typeahead/PhabricatorApplicationDatasource.php
··· 27 27 if (!$uri) { 28 28 continue; 29 29 } 30 + $is_installed = PhabricatorApplication::isClassInstalledForViewer( 31 + get_class($application), 32 + $viewer); 33 + if (!$is_installed) { 34 + continue; 35 + } 30 36 $name = $application->getName().' '.$application->getShortDescription(); 31 37 $img = 'phui-font-fa phui-icon-view '.$application->getIcon(); 32 38 $results[] = id(new PhabricatorTypeaheadResult())