+10

resources/sql/autopatches/20150708.arcanistproject.sql

reviewed

··· 1 1 + ALTER TABLE {$NAMESPACE}_differential.differential_diff 2 2 + DROP COLUMN arcanistProjectPHID; 3 3 + 4 4 + ALTER TABLE {$NAMESPACE}_differential.differential_revision 5 5 + DROP COLUMN arcanistProjectPHID; 6 6 + 7 7 + ALTER TABLE {$NAMESPACE}_releeph.releeph_project 8 8 + DROP COLUMN arcanistProjectID; 9 9 + 10 10 + DROP TABLE {$NAMESPACE}_repository.repository_arcanistproject;

-12

src/__phutil_library_map__.php

reviewed

··· 173 173 'AphrontView' => 'view/AphrontView.php', 174 174 'AphrontWebpageResponse' => 'aphront/response/AphrontWebpageResponse.php', 175 175 'ArcanistConduitAPIMethod' => 'applications/arcanist/conduit/ArcanistConduitAPIMethod.php', 176 176 - 'ArcanistProjectInfoConduitAPIMethod' => 'applications/arcanist/conduit/ArcanistProjectInfoConduitAPIMethod.php', 177 176 'AuditConduitAPIMethod' => 'applications/audit/conduit/AuditConduitAPIMethod.php', 178 177 'AuditQueryConduitAPIMethod' => 'applications/audit/conduit/AuditQueryConduitAPIMethod.php', 179 178 'AuthManageProvidersCapability' => 'applications/auth/capability/AuthManageProvidersCapability.php', ··· 2492 2491 'PhabricatorRemarkupUIExample' => 'applications/uiexample/examples/PhabricatorRemarkupUIExample.php', 2493 2492 'PhabricatorRepositoriesSetupCheck' => 'applications/config/check/PhabricatorRepositoriesSetupCheck.php', 2494 2493 'PhabricatorRepository' => 'applications/repository/storage/PhabricatorRepository.php', 2495 2495 - 'PhabricatorRepositoryArcanistProject' => 'applications/repository/storage/PhabricatorRepositoryArcanistProject.php', 2496 2496 - 'PhabricatorRepositoryArcanistProjectPHIDType' => 'applications/repository/phid/PhabricatorRepositoryArcanistProjectPHIDType.php', 2497 2497 - 'PhabricatorRepositoryArcanistProjectQuery' => 'applications/repository/query/PhabricatorRepositoryArcanistProjectQuery.php', 2498 2494 'PhabricatorRepositoryAuditRequest' => 'applications/repository/storage/PhabricatorRepositoryAuditRequest.php', 2499 2495 'PhabricatorRepositoryBranch' => 'applications/repository/storage/PhabricatorRepositoryBranch.php', 2500 2496 'PhabricatorRepositoryCommit' => 'applications/repository/storage/PhabricatorRepositoryCommit.php', ··· 3598 3594 ), 3599 3595 'AphrontWebpageResponse' => 'AphrontHTMLResponse', 3600 3596 'ArcanistConduitAPIMethod' => 'ConduitAPIMethod', 3601 3601 - 'ArcanistProjectInfoConduitAPIMethod' => 'ArcanistConduitAPIMethod', 3602 3597 'AuditConduitAPIMethod' => 'ConduitAPIMethod', 3603 3598 'AuditQueryConduitAPIMethod' => 'AuditConduitAPIMethod', 3604 3599 'AuthManageProvidersCapability' => 'PhabricatorPolicyCapability', ··· 6290 6285 'PhabricatorProjectInterface', 6291 6286 'PhabricatorSpacesInterface', 6292 6287 ), 6293 6293 - 'PhabricatorRepositoryArcanistProject' => array( 6294 6294 - 'PhabricatorRepositoryDAO', 6295 6295 - 'PhabricatorPolicyInterface', 6296 6296 - 'PhabricatorDestructibleInterface', 6297 6297 - ), 6298 6298 - 'PhabricatorRepositoryArcanistProjectPHIDType' => 'PhabricatorPHIDType', 6299 6299 - 'PhabricatorRepositoryArcanistProjectQuery' => 'PhabricatorCursorPagedPolicyAwareQuery', 6300 6288 'PhabricatorRepositoryAuditRequest' => array( 6301 6289 'PhabricatorRepositoryDAO', 6302 6290 'PhabricatorPolicyInterface',

-74

src/applications/arcanist/conduit/ArcanistProjectInfoConduitAPIMethod.php

reviewed

··· 1 1 - <?php 2 2 - 3 3 - final class ArcanistProjectInfoConduitAPIMethod 4 4 - extends ArcanistConduitAPIMethod { 5 5 - 6 6 - public function getAPIMethodName() { 7 7 - return 'arcanist.projectinfo'; 8 8 - } 9 9 - 10 10 - public function getMethodStatus() { 11 11 - return self::METHOD_STATUS_DEPRECATED; 12 12 - } 13 13 - 14 14 - public function getMethodDescription() { 15 15 - return pht('Arcanist projects are deprecated.'); 16 16 - } 17 17 - 18 18 - protected function defineParamTypes() { 19 19 - return array( 20 20 - 'name' => 'required string', 21 21 - ); 22 22 - } 23 23 - 24 24 - protected function defineReturnType() { 25 25 - return 'nonempty dict'; 26 26 - } 27 27 - 28 28 - protected function defineErrorTypes() { 29 29 - return array( 30 30 - 'ERR-BAD-ARCANIST-PROJECT' => pht('No such project exists.'), 31 31 - ); 32 32 - } 33 33 - 34 34 - protected function execute(ConduitAPIRequest $request) { 35 35 - $name = $request->getValue('name'); 36 36 - 37 37 - $project = id(new PhabricatorRepositoryArcanistProject())->loadOneWhere( 38 38 - 'name = %s', 39 39 - $name); 40 40 - 41 41 - if (!$project) { 42 42 - throw new ConduitException('ERR-BAD-ARCANIST-PROJECT'); 43 43 - } 44 44 - 45 45 - $repository = null; 46 46 - if ($project->getRepositoryID()) { 47 47 - $repository = id(new PhabricatorRepositoryQuery()) 48 48 - ->setViewer($request->getUser()) 49 49 - ->withIDs(array($project->getRepositoryID())) 50 50 - ->executeOne(); 51 51 - } 52 52 - 53 53 - $repository_phid = null; 54 54 - $tracked = false; 55 55 - $encoding = null; 56 56 - $dictionary = array(); 57 57 - if ($repository) { 58 58 - $repository_phid = $repository->getPHID(); 59 59 - $tracked = $repository->isTracked(); 60 60 - $encoding = $repository->getDetail('encoding'); 61 61 - $dictionary = $repository->toDictionary(); 62 62 - } 63 63 - 64 64 - return array( 65 65 - 'name' => $project->getName(), 66 66 - 'phid' => $project->getPHID(), 67 67 - 'repositoryPHID' => $repository_phid, 68 68 - 'tracked' => $tracked, 69 69 - 'encoding' => $encoding, 70 70 - 'repository' => $dictionary, 71 71 - ); 72 72 - } 73 73 - 74 74 - }

-1

src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php

reviewed

··· 39 39 'sourceControlPath' => 'required string', 40 40 'sourceControlBaseRevision' => 'required string', 41 41 'creationMethod' => 'optional string', 42 42 - 'arcanistProject' => 'deprecated', 43 42 'lintStatus' => 'required '.$status_const, 44 43 'unitStatus' => 'required '.$status_const, 45 44 'repositoryPHID' => 'optional phid',

-2

src/applications/differential/storage/DifferentialDiff.php

reviewed

··· 27 27 protected $branch; 28 28 protected $bookmark; 29 29 30 30 - protected $arcanistProjectPHID; 31 30 protected $creationMethod; 32 31 protected $repositoryUUID; 33 32 ··· 58 57 'lineCount' => 'uint32', 59 58 'branch' => 'text255?', 60 59 'bookmark' => 'text255?', 61 61 - 'arcanistProjectPHID' => 'phid?', 62 60 'repositoryUUID' => 'text64?', 63 61 64 62 // T6203/NULLABILITY

-2

src/applications/differential/storage/DifferentialRevision.php

reviewed

··· 30 30 31 31 protected $mailKey; 32 32 protected $branchName; 33 33 - protected $arcanistProjectPHID; 34 33 protected $repositoryPHID; 35 34 protected $viewPolicy = PhabricatorPolicies::POLICY_USER; 36 35 protected $editPolicy = PhabricatorPolicies::POLICY_USER; ··· 87 86 'lineCount' => 'uint32?', 88 87 'mailKey' => 'bytes40', 89 88 'branchName' => 'text255?', 90 90 - 'arcanistProjectPHID' => 'phid?', 91 89 'repositoryPHID' => 'phid?', 92 90 ), 93 91 self::CONFIG_KEY_SCHEMA => array(

-2

src/applications/releeph/storage/ReleephProject.php

reviewed

··· 18 18 protected $repositoryPHID; 19 19 protected $isActive; 20 20 protected $createdByUserPHID; 21 21 - protected $arcanistProjectID; 22 21 23 22 protected $details = array(); 24 23 ··· 34 33 'name' => 'text128', 35 34 'trunkBranch' => 'text255', 36 35 'isActive' => 'bool', 37 37 - 'arcanistProjectID' => 'id?', 38 36 ), 39 37 self::CONFIG_KEY_SCHEMA => array( 40 38 'projectName' => array(

-35

src/applications/repository/phid/PhabricatorRepositoryArcanistProjectPHIDType.php

reviewed

··· 1 1 - <?php 2 2 - 3 3 - final class PhabricatorRepositoryArcanistProjectPHIDType 4 4 - extends PhabricatorPHIDType { 5 5 - 6 6 - const TYPECONST = 'APRJ'; 7 7 - 8 8 - public function getTypeName() { 9 9 - return pht('Arcanist Project'); 10 10 - } 11 11 - 12 12 - public function newObject() { 13 13 - return new PhabricatorRepositoryArcanistProject(); 14 14 - } 15 15 - 16 16 - protected function buildQueryForObjects( 17 17 - PhabricatorObjectQuery $query, 18 18 - array $phids) { 19 19 - 20 20 - return id(new PhabricatorRepositoryArcanistProjectQuery()) 21 21 - ->withPHIDs($phids); 22 22 - } 23 23 - 24 24 - public function loadHandles( 25 25 - PhabricatorHandleQuery $query, 26 26 - array $handles, 27 27 - array $objects) { 28 28 - 29 29 - foreach ($handles as $phid => $handle) { 30 30 - $project = $objects[$phid]; 31 31 - $handle->setName($project->getName()); 32 32 - } 33 33 - } 34 34 - 35 35 - }

-87

src/applications/repository/query/PhabricatorRepositoryArcanistProjectQuery.php

reviewed

··· 1 1 - <?php 2 2 - 3 3 - final class PhabricatorRepositoryArcanistProjectQuery 4 4 - extends PhabricatorCursorPagedPolicyAwareQuery { 5 5 - 6 6 - private $ids; 7 7 - private $phids; 8 8 - 9 9 - private $needRepositories; 10 10 - 11 11 - public function withIDs(array $ids) { 12 12 - $this->ids = $ids; 13 13 - return $this; 14 14 - } 15 15 - 16 16 - public function withPHIDs(array $phids) { 17 17 - $this->phids = $phids; 18 18 - return $this; 19 19 - } 20 20 - 21 21 - public function needRepositories($need_repositories) { 22 22 - $this->needRepositories = $need_repositories; 23 23 - return $this; 24 24 - } 25 25 - 26 26 - protected function loadPage() { 27 27 - $table = new PhabricatorRepositoryArcanistProject(); 28 28 - $conn_r = $table->establishConnection('r'); 29 29 - 30 30 - $data = queryfx_all( 31 31 - $conn_r, 32 32 - 'SELECT * FROM %T %Q %Q %Q', 33 33 - $table->getTableName(), 34 34 - $this->buildWhereClause($conn_r), 35 35 - $this->buildOrderClause($conn_r), 36 36 - $this->buildLimitClause($conn_r)); 37 37 - 38 38 - return $table->loadAllFromArray($data); 39 39 - } 40 40 - 41 41 - protected function willFilterPage(array $projects) { 42 42 - assert_instances_of($projects, 'PhabricatorRepositoryArcanistProject'); 43 43 - 44 44 - if ($this->needRepositories) { 45 45 - $repository_ids = mpull($projects, 'getRepositoryID'); 46 46 - $repositories = id(new PhabricatorRepositoryQuery()) 47 47 - ->setViewer($this->getViewer()) 48 48 - ->withIDs($repository_ids) 49 49 - ->execute(); 50 50 - foreach ($projects as $project) { 51 51 - $repo = idx($repositories, $project->getRepositoryID()); 52 52 - $project->attachRepository($repo); 53 53 - } 54 54 - } 55 55 - 56 56 - return $projects; 57 57 - } 58 58 - 59 59 - protected function buildWhereClause(AphrontDatabaseConnection $conn_r) { 60 60 - $where = array(); 61 61 - 62 62 - if ($this->ids) { 63 63 - $where[] = qsprintf( 64 64 - $conn_r, 65 65 - 'id IN (%Ld)', 66 66 - $this->ids); 67 67 - } 68 68 - 69 69 - if ($this->phids) { 70 70 - $where[] = qsprintf( 71 71 - $conn_r, 72 72 - 'phid IN (%Ls)', 73 73 - $this->phids); 74 74 - } 75 75 - 76 76 - $where[] = $this->buildPagingClause($conn_r); 77 77 - 78 78 - return $this->formatWhereClause($where); 79 79 - } 80 80 - 81 81 - 82 82 - public function getQueryApplicationClass() { 83 83 - // TODO: Diffusion? Differential? 84 84 - return null; 85 85 - } 86 86 - 87 87 - }

-6

src/applications/repository/storage/PhabricatorRepository.php

reviewed

··· 1169 1169 $path->delete(); 1170 1170 } 1171 1171 1172 1172 - $projects = id(new PhabricatorRepositoryArcanistProject()) 1173 1173 - ->loadAllWhere('repositoryID = %d', $this->getID()); 1174 1174 - foreach ($projects as $project) { 1175 1175 - $project->delete(); 1176 1176 - } 1177 1177 - 1178 1172 queryfx( 1179 1173 $this->establishConnection('w'), 1180 1174 'DELETE FROM %T WHERE repositoryPHID = %s',

-89

src/applications/repository/storage/PhabricatorRepositoryArcanistProject.php

reviewed

··· 1 1 - <?php 2 2 - 3 3 - final class PhabricatorRepositoryArcanistProject 4 4 - extends PhabricatorRepositoryDAO 5 5 - implements 6 6 - PhabricatorPolicyInterface, 7 7 - PhabricatorDestructibleInterface { 8 8 - 9 9 - protected $name; 10 10 - protected $repositoryID; 11 11 - 12 12 - private $repository = self::ATTACHABLE; 13 13 - 14 14 - protected function getConfiguration() { 15 15 - return array( 16 16 - self::CONFIG_AUX_PHID => true, 17 17 - self::CONFIG_TIMESTAMPS => false, 18 18 - self::CONFIG_COLUMN_SCHEMA => array( 19 19 - 'name' => 'text128', 20 20 - 'repositoryID' => 'id?', 21 21 - ), 22 22 - self::CONFIG_KEY_SCHEMA => array( 23 23 - 'key_phid' => null, 24 24 - 'phid' => array( 25 25 - 'columns' => array('phid'), 26 26 - 'unique' => true, 27 27 - ), 28 28 - 'name' => array( 29 29 - 'columns' => array('name'), 30 30 - 'unique' => true, 31 31 - ), 32 32 - ), 33 33 - ) + parent::getConfiguration(); 34 34 - } 35 35 - 36 36 - public function generatePHID() { 37 37 - return PhabricatorPHID::generateNewPHID( 38 38 - PhabricatorRepositoryArcanistProjectPHIDType::TYPECONST); 39 39 - } 40 40 - 41 41 - public function getRepository() { 42 42 - return $this->assertAttached($this->repository); 43 43 - } 44 44 - 45 45 - public function attachRepository(PhabricatorRepository $repository = null) { 46 46 - $this->repository = $repository; 47 47 - return $this; 48 48 - } 49 49 - 50 50 - 51 51 - 52 52 - /* -( PhabricatorPolicyInterface )----------------------------------------- */ 53 53 - 54 54 - public function getCapabilities() { 55 55 - return array( 56 56 - PhabricatorPolicyCapability::CAN_VIEW, 57 57 - PhabricatorPolicyCapability::CAN_EDIT, 58 58 - ); 59 59 - } 60 60 - 61 61 - public function getPolicy($capability) { 62 62 - switch ($capability) { 63 63 - case PhabricatorPolicyCapability::CAN_VIEW: 64 64 - return PhabricatorPolicies::POLICY_USER; 65 65 - case PhabricatorPolicyCapability::CAN_EDIT: 66 66 - return PhabricatorPolicies::POLICY_ADMIN; 67 67 - } 68 68 - } 69 69 - 70 70 - public function hasAutomaticCapability($capability, PhabricatorUser $viewer) { 71 71 - return false; 72 72 - } 73 73 - 74 74 - public function describeAutomaticCapability($capability) { 75 75 - return null; 76 76 - } 77 77 - 78 78 - 79 79 - /* -( PhabricatorDestructibleInterface )----------------------------------- */ 80 80 - 81 81 - public function destroyObjectPermanently( 82 82 - PhabricatorDestructionEngine $engine) { 83 83 - 84 84 - $this->openTransaction(); 85 85 - $this->delete(); 86 86 - $this->saveTransaction(); 87 87 - } 88 88 - 89 89 - }