Fix HarbormasterBuildUnitMessage PHP 8.1 strlen(null) error

@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge

phorge phabricator

fork

Summary:
Fix HarbormasterBuildUnitMessage PHP 8.1 strlen(null) error.

Fixes T15572

Test Plan: Do an 'arc diff' to a PHP 8.1 Phorge server when doing so will trigger unit tests.

Reviewers: O1 Blessed Committers, speck

Reviewed By: O1 Blessed Committers, speck

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15572

Differential Revision: https://we.phorge.it/D25365

sten 2 years ago 007e7621 1802ebd2

+1 -1

1 changed file

expand all

src

applications

harbormaster

storage

build

HarbormasterBuildUnitMessage.php

+1 -1

src/applications/harbormaster/storage/build/HarbormasterBuildUnitMessage.php

··· 102 102 $obj->setDuration((float)idx($dict, 'duration')); 103 103 104 104 $path = idx($dict, 'path'); 105 - if (strlen($path)) { 105 + if ($path !== null && strlen($path)) { 106 106 $obj->setProperty('path', $path); 107 107 } 108 108

Configure Feed

Configure Feed