@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Set up colspec for differential 1up
Summary: This upgrades 1up view from "does not work" back to "barely works".
Test Plan: view diff, 1up and 2up.
Reviewers: #blessed_reviewers, epriestley
Reviewed By: #blessed_reviewers, epriestley
Subscribers: epriestley
Differential Revision: https://secure.phabricator.com/D10854
authored by
Aviv Eyal
and committed by
epriestley
00b245a5
c9c4dc1d
+21
-10
+2
-10
src/applications/differential/render/DifferentialChangesetHTMLRenderer.php
+2
-10
src/applications/differential/render/DifferentialChangesetHTMLRenderer.php
···
409
409
$content)));
410
410
}
411
411
412
-
private function renderColgroup() {
413
-
return phutil_tag('colgroup', array(), array(
414
-
phutil_tag('col', array('class' => 'num')),
415
-
phutil_tag('col', array('class' => 'left')),
416
-
phutil_tag('col', array('class' => 'num')),
417
-
phutil_tag('col', array('class' => 'copy')),
418
-
phutil_tag('col', array('class' => 'right')),
419
-
phutil_tag('col', array('class' => 'cov')),
420
-
));
421
-
}
412
+
abstract protected function renderColgroup();
413
+
422
414
423
415
protected function wrapChangeInTable($content) {
424
416
if (!$content) {
+8
src/applications/differential/render/DifferentialChangesetOneUpRenderer.php
+8
src/applications/differential/render/DifferentialChangesetOneUpRenderer.php
···
7
7
return true;
8
8
}
9
9
10
+
protected function renderColgroup() {
11
+
return phutil_tag('colgroup', array(), array(
12
+
phutil_tag('col', array('class' => 'num')),
13
+
phutil_tag('col', array('class' => 'num')),
14
+
phutil_tag('col', array('class' => 'unified')),
15
+
));
16
+
}
17
+
10
18
public function renderTextChange(
11
19
$range_start,
12
20
$range_len,
+11
src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php
+11
src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php
···
7
7
return false;
8
8
}
9
9
10
+
protected function renderColgroup() {
11
+
return phutil_tag('colgroup', array(), array(
12
+
phutil_tag('col', array('class' => 'num')),
13
+
phutil_tag('col', array('class' => 'left')),
14
+
phutil_tag('col', array('class' => 'num')),
15
+
phutil_tag('col', array('class' => 'copy')),
16
+
phutil_tag('col', array('class' => 'right')),
17
+
phutil_tag('col', array('class' => 'cov')),
18
+
));
19
+
}
20
+
10
21
public function renderTextChange(
11
22
$range_start,
12
23
$range_len,