@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up logged out prompt on TransactionComments
Summary: We were getting a weird double box here, missed it my first pass
Test Plan: Review logged in Maniphest and Paste, as well as logged out versions. Test Login flow.
Reviewers: epriestley
Reviewed By: epriestley
CC: Korvin, epriestley, aran
Differential Revision: https://secure.phabricator.com/D7716
+7
-6
+6
-6
src/applications/maniphest/controller/ManiphestTaskDetailController.php
+6
-6
src/applications/maniphest/controller/ManiphestTaskDetailController.php
···
382
382
if (!$user->isLoggedIn()) {
383
383
// TODO: Eventually, everything should run through this. For now, we're
384
384
// only using it to get a consistent "Login to Comment" button.
385
-
$comment_form = id(new PhabricatorApplicationTransactionCommentView())
385
+
$comment_box = id(new PhabricatorApplicationTransactionCommentView())
386
386
->setUser($user)
387
387
->setRequestURI($request->getRequestURI());
388
388
$preview_panel = null;
389
+
} else {
390
+
$comment_box = id(new PHUIObjectBoxView())
391
+
->setFlush(true)
392
+
->setHeaderText($comment_header)
393
+
->appendChild($comment_form);
389
394
}
390
395
391
396
$object_box = id(new PHUIObjectBoxView())
···
395
400
if ($description) {
396
401
$object_box->addPropertyList($description);
397
402
}
398
-
399
-
$comment_box = id(new PHUIObjectBoxView())
400
-
->setFlush(true)
401
-
->setHeaderText($comment_header)
402
-
->appendChild($comment_form);
403
403
404
404
return $this->buildApplicationPage(
405
405
array(
+1
src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
+1
src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php