@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Save ApplicationSearch queries generated from GET parameters in the request
Summary:
Fixes T4239. Currently, if you go to `/maniphest/?authors=alincoln`, operations dependent on the query key (like "Save Custom Query..." and "Export to Excel...") don't have a query key to work with. Make sure they have one.
Also remove a stray `phlog()`.
Test Plan: "Save Custom Query...", etc., now work on GET queries.
Reviewers: btrahan, chad
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T4239
Differential Revision: https://secure.phabricator.com/D7777
+4
-1
+4
src/applications/search/controller/PhabricatorApplicationSearchController.php
+4
src/applications/search/controller/PhabricatorApplicationSearchController.php
···
147
147
$named_query = idx($engine->loadEnabledNamedQueries(), $query_key);
148
148
} else {
149
149
$saved_query = $engine->buildSavedQueryFromRequest($request);
150
+
151
+
// Save the query to generate a query key, so "Save Custom Query..." and
152
+
// other features like Maniphest's "Export..." work correctly.
153
+
$this->saveQuery($saved_query);
150
154
}
151
155
152
156
$nav->selectFilter(
-1
src/applications/search/engine/PhabricatorApplicationSearchEngine.php
-1
src/applications/search/engine/PhabricatorApplicationSearchEngine.php