@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix mobile action menus in Phriction
Summary: Fixes T6963. Long term will likely make this more like other document views, but not worth the time right now since this is only location.
Test Plan: Review Phriction document at desktop and mobile breakpoints. Click menu and see menu.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T6963
Differential Revision: https://secure.phabricator.com/D11420
+30
+3
src/applications/phriction/controller/PhrictionDocumentController.php
+3
src/applications/phriction/controller/PhrictionDocumentController.php
···
200
200
$prop_list = new PHUIPropertyGroupView();
201
201
$prop_list->addPropertyList($properties);
202
202
}
203
+
$action_id = celerity_generate_unique_node_id();
204
+
$actions->setID($action_id);
203
205
204
206
$page_content = id(new PHUIDocumentView())
205
207
->setOffset(true)
206
208
->setFontKit(PHUIDocumentView::FONT_SOURCE_SANS)
207
209
->setHeader($header)
210
+
->setActionListID($action_id)
208
211
->appendChild(
209
212
array(
210
213
$actions,
+27
src/view/phui/PHUIDocumentView.php
+27
src/view/phui/PHUIDocumentView.php
···
16
16
private $bookdescription;
17
17
private $mobileview;
18
18
private $fontKit;
19
+
private $actionListID;
19
20
20
21
public function setOffset($offset) {
21
22
$this->offset = $offset;
···
54
55
55
56
public function setFontKit($kit) {
56
57
$this->fontKit = $kit;
58
+
return $this;
59
+
}
60
+
61
+
public function setActionListID($id) {
62
+
$this->actionListID = $id;
57
63
return $this;
58
64
}
59
65
···
148
154
$this->renderChildren());
149
155
} else {
150
156
$main_content = $this->renderChildren();
157
+
}
158
+
159
+
if ($this->actionListID) {
160
+
$icon_id = celerity_generate_unique_node_id();
161
+
$icon = id(new PHUIIconView())
162
+
->setIconFont('fa-bars');
163
+
$meta = array(
164
+
'map' => array(
165
+
$this->actionListID => 'phabricator-action-list-toggle',
166
+
$icon_id => 'phuix-dropdown-open',
167
+
),);
168
+
$mobile_menu = id(new PHUIButtonView())
169
+
->setTag('a')
170
+
->setText(pht('Actions'))
171
+
->setHref('#')
172
+
->setIcon($icon)
173
+
->addClass('phui-mobile-menu')
174
+
->setID($icon_id)
175
+
->addSigil('jx-toggle-class')
176
+
->setMetadata($meta);
177
+
$this->header->addActionLink($mobile_menu);
151
178
}
152
179
153
180
$content_inner = phutil_tag(