@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
In Webhooks, label HTTP response codes as "HTTP Status Code", not "HTTP Error"
Summary: See PHI1068. We currently show "HTTP Error - 200", which is misleading. Instead, label these results as "HTTP Status Code".
Test Plan: {F6206016}
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D20148
+1
-1
+1
-1
src/applications/herald/storage/HeraldWebhookRequest.php
+1
-1
src/applications/herald/storage/HeraldWebhookRequest.php
···
120
120
public function getErrorTypeForDisplay() {
121
121
$map = array(
122
122
self::ERRORTYPE_HOOK => pht('Hook Error'),
123
-
self::ERRORTYPE_HTTP => pht('HTTP Error'),
123
+
self::ERRORTYPE_HTTP => pht('HTTP Status Code'),
124
124
self::ERRORTYPE_TIMEOUT => pht('Request Timeout'),
125
125
);
126
126