@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Apply some autofix linter rules

Summary: Self-explanatory.

Test Plan: Eyeball it.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D10454

+84 -241
+1 -2
src/aphront/configuration/AphrontApplicationConfiguration.php
··· 52 52 return $this->path; 53 53 } 54 54 55 - public function willBuildRequest() { 56 - } 55 + public function willBuildRequest() {} 57 56 58 57 59 58 /* -( URI Routing )-------------------------------------------------------- */
+1 -3
src/aphront/exception/AphrontCSRFException.php
··· 1 1 <?php 2 2 3 - final class AphrontCSRFException extends AphrontException { 4 - 5 - } 3 + final class AphrontCSRFException extends AphrontException {}
+1 -3
src/aphront/exception/AphrontException.php
··· 1 1 <?php 2 2 3 - abstract class AphrontException extends Exception { 4 - 5 - } 3 + abstract class AphrontException extends Exception {}
+1 -3
src/applications/audit/management/PhabricatorAuditManagementWorkflow.php
··· 1 1 <?php 2 2 3 3 abstract class PhabricatorAuditManagementWorkflow 4 - extends PhabricatorManagementWorkflow { 5 - 6 - } 4 + extends PhabricatorManagementWorkflow {}
+1 -3
src/applications/auth/data/PhabricatorAuthHighSecurityToken.php
··· 1 1 <?php 2 2 3 - final class PhabricatorAuthHighSecurityToken { 4 - 5 - } 3 + final class PhabricatorAuthHighSecurityToken {}
+1 -3
src/applications/auth/management/PhabricatorAuthManagementWorkflow.php
··· 1 1 <?php 2 2 3 3 abstract class PhabricatorAuthManagementWorkflow 4 - extends PhabricatorManagementWorkflow { 5 - 6 - } 4 + extends PhabricatorManagementWorkflow {}
+1 -3
src/applications/base/controller/__tests__/PhabricatorTestController.php
··· 33 33 return $this->getConfig('enabled', parent::shouldRequireEnabledUser()); 34 34 } 35 35 36 - public function processRequest() { 37 - 38 - } 36 + public function processRequest() {} 39 37 40 38 }
+1 -3
src/applications/cache/management/PhabricatorCacheManagementWorkflow.php
··· 1 1 <?php 2 2 3 3 abstract class PhabricatorCacheManagementWorkflow 4 - extends PhabricatorManagementWorkflow { 5 - 6 - } 4 + extends PhabricatorManagementWorkflow {}
+1 -2
src/applications/calendar/exception/PhabricatorCalendarEventInvalidEpochException.php
··· 1 1 <?php 2 2 3 - final class PhabricatorCalendarEventInvalidEpochException extends Exception { 4 - } 3 + final class PhabricatorCalendarEventInvalidEpochException extends Exception {}
+1 -3
src/applications/chatlog/constants/PhabricatorChatLogConstants.php
··· 1 1 <?php 2 2 3 - abstract class PhabricatorChatLogConstants { 4 - 5 - } 3 + abstract class PhabricatorChatLogConstants {}
+1 -3
src/applications/chatlog/controller/PhabricatorChatLogController.php
··· 1 1 <?php 2 2 3 - abstract class PhabricatorChatLogController extends PhabricatorController { 4 - 5 - } 3 + abstract class PhabricatorChatLogController extends PhabricatorController {}
+1 -3
src/applications/conduit/protocol/exception/ConduitMethodNotFoundException.php
··· 1 1 <?php 2 2 3 - abstract class ConduitMethodNotFoundException extends ConduitException { 4 - 5 - } 3 + abstract class ConduitMethodNotFoundException extends ConduitException {}
+1 -3
src/applications/config/exception/PhabricatorConfigValidationException.php
··· 1 1 <?php 2 2 3 - final class PhabricatorConfigValidationException extends Exception { 4 - 5 - } 3 + final class PhabricatorConfigValidationException extends Exception {}
+1 -3
src/applications/config/management/PhabricatorConfigManagementWorkflow.php
··· 1 1 <?php 2 2 3 3 abstract class PhabricatorConfigManagementWorkflow 4 - extends PhabricatorManagementWorkflow { 5 - 6 - } 4 + extends PhabricatorManagementWorkflow {}
+1 -3
src/applications/dashboard/controller/PhabricatorDashboardController.php
··· 1 1 <?php 2 2 3 - abstract class PhabricatorDashboardController extends PhabricatorController { 4 - 5 - } 3 + abstract class PhabricatorDashboardController extends PhabricatorController {}
+1 -3
src/applications/dashboard/customfield/PhabricatorDashboardPanelCustomField.php
··· 1 1 <?php 2 2 3 3 abstract class PhabricatorDashboardPanelCustomField 4 - extends PhabricatorCustomField { 5 - 6 - } 4 + extends PhabricatorCustomField {}
+1 -2
src/applications/differential/editor/DifferentialTransactionEditor.php
··· 1040 1040 PhabricatorLiskDAO $object, 1041 1041 PhabricatorApplicationTransaction $xaction) { 1042 1042 1043 - switch ($xaction->getTransactionType()) { 1044 - } 1043 + switch ($xaction->getTransactionType()) {} 1045 1044 1046 1045 return parent::requireCapabilities($object, $xaction); 1047 1046 }
+1 -3
src/applications/differential/exception/DifferentialDiffCreationRejectException.php
··· 1 1 <?php 2 2 3 - final class DifferentialDiffCreationRejectException extends Exception { 4 - 5 - } 3 + final class DifferentialDiffCreationRejectException extends Exception {}
+1 -3
src/applications/differential/exception/DifferentialFieldParseException.php
··· 1 1 <?php 2 2 3 - final class DifferentialFieldParseException extends Exception { 4 - 5 - } 3 + final class DifferentialFieldParseException extends Exception {}
+1 -3
src/applications/differential/exception/DifferentialFieldValidationException.php
··· 1 1 <?php 2 2 3 - final class DifferentialFieldValidationException extends Exception { 4 - 5 - } 3 + final class DifferentialFieldValidationException extends Exception {}
+1 -3
src/applications/differential/management/PhabricatorHunksManagementWorkflow.php
··· 1 1 <?php 2 2 3 3 abstract class PhabricatorHunksManagementWorkflow 4 - extends PhabricatorManagementWorkflow { 5 - 6 - } 4 + extends PhabricatorManagementWorkflow {}
+2 -4
src/applications/diffusion/controller/DiffusionBrowseSearchController.php
··· 133 133 134 134 try { 135 135 Futures($futures)->limit(8)->resolveAll(); 136 - } catch (PhutilSyntaxHighlighterException $ex) { 137 - } 136 + } catch (PhutilSyntaxHighlighterException $ex) {} 138 137 139 138 $rows = array(); 140 139 foreach ($results as $result) { ··· 148 147 149 148 try { 150 149 $string = $futures["{$path}:{$line}"]->resolve(); 151 - } catch (PhutilSyntaxHighlighterException $ex) { 152 - } 150 + } catch (PhutilSyntaxHighlighterException $ex) {} 153 151 154 152 $string = phutil_tag( 155 153 'pre',
+1 -3
src/applications/diffusion/controller/DiffusionPushLogController.php
··· 1 1 <?php 2 2 3 - abstract class DiffusionPushLogController extends DiffusionController { 4 - 5 - } 3 + abstract class DiffusionPushLogController extends DiffusionController {}
+1 -3
src/applications/diffusion/exception/DiffusionCommitHookRejectException.php
··· 1 1 <?php 2 2 3 - final class DiffusionCommitHookRejectException extends Exception { 4 - 5 - } 3 + final class DiffusionCommitHookRejectException extends Exception {}
+1 -3
src/applications/diffusion/ssh/DiffusionSSHMercurialWorkflow.php
··· 1 1 <?php 2 2 3 - abstract class DiffusionSSHMercurialWorkflow extends DiffusionSSHWorkflow { 4 - 5 - } 3 + abstract class DiffusionSSHMercurialWorkflow extends DiffusionSSHWorkflow {}
+1 -3
src/applications/doorkeeper/exception/DoorkeeperMissingLinkException.php
··· 1 1 <?php 2 2 3 - final class DoorkeeperMissingLinkException extends Exception { 4 - 5 - } 3 + final class DoorkeeperMissingLinkException extends Exception {}
+1 -3
src/applications/drydock/constants/DrydockConstants.php
··· 1 1 <?php 2 2 3 - abstract class DrydockConstants { 4 - 5 - } 3 + abstract class DrydockConstants {}
+1 -3
src/applications/drydock/customfield/DrydockBlueprintCustomField.php
··· 1 1 <?php 2 2 3 3 abstract class DrydockBlueprintCustomField 4 - extends PhabricatorCustomField { 5 - 6 - } 4 + extends PhabricatorCustomField {}
+1 -3
src/applications/drydock/management/DrydockManagementWorkflow.php
··· 1 1 <?php 2 2 3 3 abstract class DrydockManagementWorkflow 4 - extends PhabricatorManagementWorkflow { 5 - 6 - } 4 + extends PhabricatorManagementWorkflow {}
+1 -3
src/applications/drydock/query/DrydockBlueprintSearchEngine.php
··· 21 21 22 22 public function buildSearchForm( 23 23 AphrontFormView $form, 24 - PhabricatorSavedQuery $saved) { 25 - 26 - } 24 + PhabricatorSavedQuery $saved) {} 27 25 28 26 protected function getURI($path) { 29 27 return '/drydock/blueprint/'.$path;
+1 -3
src/applications/drydock/query/DrydockLogSearchEngine.php
··· 20 20 21 21 public function buildSearchForm( 22 22 AphrontFormView $form, 23 - PhabricatorSavedQuery $saved) { 24 - 25 - } 23 + PhabricatorSavedQuery $saved) {} 26 24 27 25 protected function getURI($path) { 28 26 return '/drydock/log/'.$path;
+1 -3
src/applications/fact/controller/PhabricatorFactController.php
··· 1 1 <?php 2 2 3 - abstract class PhabricatorFactController extends PhabricatorController { 4 - 5 - } 3 + abstract class PhabricatorFactController extends PhabricatorController {}
+1 -3
src/applications/fact/management/PhabricatorFactManagementWorkflow.php
··· 1 1 <?php 2 2 3 3 abstract class PhabricatorFactManagementWorkflow 4 - extends PhabricatorManagementWorkflow { 5 - 6 - } 4 + extends PhabricatorManagementWorkflow {}
+1 -3
src/applications/feed/constants/PhabricatorFeedConstants.php
··· 1 1 <?php 2 2 3 - abstract class PhabricatorFeedConstants { 4 - 5 - } 3 + abstract class PhabricatorFeedConstants {}
+1 -3
src/applications/feed/management/PhabricatorFeedManagementWorkflow.php
··· 1 1 <?php 2 2 3 3 abstract class PhabricatorFeedManagementWorkflow 4 - extends PhabricatorManagementWorkflow { 5 - 6 - } 4 + extends PhabricatorManagementWorkflow {}
+3 -8
src/applications/files/editor/PhabricatorFileEditor.php
··· 22 22 23 23 protected function getCustomTransactionOldValue( 24 24 PhabricatorLiskDAO $object, 25 - PhabricatorApplicationTransaction $xaction) { 26 - 27 - } 25 + PhabricatorApplicationTransaction $xaction) {} 28 26 29 27 protected function getCustomTransactionNewValue( 30 28 PhabricatorLiskDAO $object, 31 - PhabricatorApplicationTransaction $xaction) { 32 - 33 - } 29 + PhabricatorApplicationTransaction $xaction) {} 34 30 35 31 protected function applyCustomInternalTransaction( 36 32 PhabricatorLiskDAO $object, ··· 45 41 46 42 protected function applyCustomExternalTransaction( 47 43 PhabricatorLiskDAO $object, 48 - PhabricatorApplicationTransaction $xaction) { 49 - } 44 + PhabricatorApplicationTransaction $xaction) {} 50 45 51 46 protected function shouldSendMail( 52 47 PhabricatorLiskDAO $object,
+1 -3
src/applications/flag/constants/PhabricatorFlagConstants.php
··· 1 1 <?php 2 2 3 - abstract class PhabricatorFlagConstants { 4 - 5 - } 3 + abstract class PhabricatorFlagConstants {}
+1 -3
src/applications/flag/interface/PhabricatorFlaggableInterface.php
··· 1 1 <?php 2 2 3 - interface PhabricatorFlaggableInterface extends PhabricatorPHIDInterface { 4 - 5 - } 3 + interface PhabricatorFlaggableInterface extends PhabricatorPHIDInterface {}
+1 -3
src/applications/harbormaster/customfield/HarbormasterBuildStepCustomField.php
··· 1 1 <?php 2 2 3 3 abstract class HarbormasterBuildStepCustomField 4 - extends PhabricatorCustomField { 5 - 6 - } 4 + extends PhabricatorCustomField {}
+1 -3
src/applications/harbormaster/exception/HarbormasterBuildAbortedException.php
··· 1 1 <?php 2 2 3 - final class HarbormasterBuildAbortedException extends Exception { 4 - 5 - } 3 + final class HarbormasterBuildAbortedException extends Exception {}
+1 -3
src/applications/harbormaster/exception/HarbormasterBuildFailureException.php
··· 1 1 <?php 2 2 3 - final class HarbormasterBuildFailureException extends Exception { 4 - 5 - } 3 + final class HarbormasterBuildFailureException extends Exception {}
+1 -3
src/applications/harbormaster/management/HarbormasterManagementWorkflow.php
··· 1 1 <?php 2 2 3 3 abstract class HarbormasterManagementWorkflow 4 - extends PhabricatorManagementWorkflow { 5 - 6 - } 4 + extends PhabricatorManagementWorkflow {}
+1 -3
src/applications/lipsum/management/PhabricatorLipsumManagementWorkflow.php
··· 1 1 <?php 2 2 3 3 abstract class PhabricatorLipsumManagementWorkflow 4 - extends PhabricatorManagementWorkflow { 5 - 6 - } 4 + extends PhabricatorManagementWorkflow {}
+1 -3
src/applications/metamta/constants/MetaMTAConstants.php
··· 1 1 <?php 2 2 3 - abstract class MetaMTAConstants { 4 - 5 - } 3 + abstract class MetaMTAConstants {}
+1 -3
src/applications/metamta/controller/PhabricatorMetaMTAController.php
··· 1 1 <?php 2 2 3 - abstract class PhabricatorMetaMTAController extends PhabricatorController { 4 - 5 - } 3 + abstract class PhabricatorMetaMTAController extends PhabricatorController {}
+1 -3
src/applications/metamta/exception/PhabricatorMetaMTAPermanentFailureException.php
··· 1 1 <?php 2 2 3 3 final class PhabricatorMetaMTAPermanentFailureException 4 - extends Exception { 5 - 6 - } 4 + extends Exception {}
+1 -3
src/applications/metamta/management/PhabricatorMailManagementWorkflow.php
··· 1 1 <?php 2 2 3 3 abstract class PhabricatorMailManagementWorkflow 4 - extends PhabricatorManagementWorkflow { 5 - 6 - } 4 + extends PhabricatorManagementWorkflow {}
+1 -3
src/applications/nuance/constants/NuanceConstants.php
··· 1 1 <?php 2 2 3 - abstract class NuanceConstants { 4 - 5 - } 3 + abstract class NuanceConstants {}
+1 -3
src/applications/nuance/controller/NuanceController.php
··· 1 1 <?php 2 2 3 - abstract class NuanceController extends PhabricatorController { 4 - 5 - } 3 + abstract class NuanceController extends PhabricatorController {}
+2 -4
src/applications/nuance/source/NuancePhabricatorFormSourceDefinition.php
··· 34 34 return $transactions; 35 35 } 36 36 37 - public function renderView() { 38 - } 37 + public function renderView() {} 39 38 40 - public function renderListView() { 41 - } 39 + public function renderListView() {} 42 40 43 41 }
+1 -4
src/applications/people/customfield/PhabricatorUserCustomField.php
··· 1 1 <?php 2 2 3 3 abstract class PhabricatorUserCustomField 4 - extends PhabricatorCustomField { 5 - 6 - 7 - } 4 + extends PhabricatorCustomField {}
+1 -2
src/applications/people/lipsum/PhabricatorPeopleTestDataGenerator.php
··· 25 25 ->createNewUser($user, $email_object); 26 26 27 27 return $user; 28 - } catch (AphrontDuplicateKeyQueryException $ex) { 29 - } 28 + } catch (AphrontDuplicateKeyQueryException $ex) {} 30 29 } 31 30 } 32 31
+1 -3
src/applications/phid/handle/const/PhabricatorObjectHandleConstants.php
··· 1 1 <?php 2 2 3 - abstract class PhabricatorObjectHandleConstants { 4 - 5 - } 3 + abstract class PhabricatorObjectHandleConstants {}
+1 -3
src/applications/phortune/constants/PhortuneConstants.php
··· 1 1 <?php 2 2 3 - abstract class PhortuneConstants { 4 - 5 - } 3 + abstract class PhortuneConstants {}
+1 -3
src/applications/phrequent/interface/PhrequentTrackableInterface.php
··· 1 1 <?php 2 2 3 - interface PhrequentTrackableInterface { 4 - 5 - } 3 + interface PhrequentTrackableInterface {}
+1 -3
src/applications/policy/constants/PhabricatorPolicyConstants.php
··· 1 1 <?php 2 2 3 - abstract class PhabricatorPolicyConstants { 4 - 5 - } 3 + abstract class PhabricatorPolicyConstants {}
+1 -3
src/applications/policy/controller/PhabricatorPolicyController.php
··· 1 1 <?php 2 2 3 - abstract class PhabricatorPolicyController extends PhabricatorController { 4 - 5 - } 3 + abstract class PhabricatorPolicyController extends PhabricatorController {}
+1 -3
src/applications/policy/management/PhabricatorPolicyManagementWorkflow.php
··· 1 1 <?php 2 2 3 3 abstract class PhabricatorPolicyManagementWorkflow 4 - extends PhabricatorManagementWorkflow { 5 - 6 - } 4 + extends PhabricatorManagementWorkflow {}
+1 -2
src/applications/ponder/constants/PonderConstants.php
··· 1 1 <?php 2 2 3 - abstract class PonderConstants { 4 - } 3 + abstract class PonderConstants {}
+1 -3
src/applications/project/constants/PhabricatorProjectConstants.php
··· 1 1 <?php 2 2 3 - abstract class PhabricatorProjectConstants { 4 - 5 - } 3 + abstract class PhabricatorProjectConstants {}
+1 -3
src/applications/project/exception/PhabricatorProjectNameCollisionException.php
··· 4 4 * Thrown when you try to save a project with a name too similar to another 5 5 * project. 6 6 */ 7 - final class PhabricatorProjectNameCollisionException extends Exception { 8 - 9 - } 7 + final class PhabricatorProjectNameCollisionException extends Exception {}
+1 -3
src/applications/project/interface/PhabricatorProjectInterface.php
··· 1 1 <?php 2 2 3 - interface PhabricatorProjectInterface { 4 - 5 - } 3 + interface PhabricatorProjectInterface {}
+2 -6
src/applications/project/query/PhabricatorProjectSearchEngine.php
··· 193 193 ); 194 194 } 195 195 196 - private function getColorValues() { 197 - 198 - } 199 - 200 - private function getIconValues() { 196 + private function getColorValues() {} 201 197 202 - } 198 + private function getIconValues() {} 203 199 204 200 protected function getRequiredHandlePHIDsForResultList( 205 201 array $projects,
+1 -3
src/applications/releeph/controller/request/ReleephRequestController.php
··· 1 1 <?php 2 2 3 - abstract class ReleephRequestController extends ReleephController { 4 - 5 - } 3 + abstract class ReleephRequestController extends ReleephController {}
+1 -4
src/applications/repository/customfield/PhabricatorCommitCustomField.php
··· 1 1 <?php 2 2 3 3 abstract class PhabricatorCommitCustomField 4 - extends PhabricatorCustomField { 5 - 6 - 7 - } 4 + extends PhabricatorCustomField {}
+2 -5
src/applications/repository/editor/PhabricatorRepositoryEditor.php
··· 257 257 PhabricatorApplicationTransaction $v) { 258 258 259 259 $type = $u->getTransactionType(); 260 - switch ($type) { 261 - } 260 + switch ($type) {} 262 261 263 262 return parent::mergeTransactions($u, $v); 264 263 } ··· 271 270 $new = $xaction->getNewValue(); 272 271 273 272 $type = $xaction->getTransactionType(); 274 - switch ($type) { 275 - 276 - } 273 + switch ($type) {} 277 274 278 275 return parent::transactionHasEffect($object, $xaction); 279 276 }
+1 -3
src/applications/search/management/PhabricatorSearchManagementWorkflow.php
··· 1 1 <?php 2 2 3 3 abstract class PhabricatorSearchManagementWorkflow 4 - extends PhabricatorManagementWorkflow { 5 - 6 - } 4 + extends PhabricatorManagementWorkflow {}
+1 -3
src/applications/system/management/PhabricatorSystemRemoveWorkflow.php
··· 1 1 <?php 2 2 3 3 abstract class PhabricatorSystemRemoveWorkflow 4 - extends PhabricatorManagementWorkflow { 5 - 6 - } 4 + extends PhabricatorManagementWorkflow {}
+1 -3
src/infrastructure/celerity/management/CelerityManagementWorkflow.php
··· 1 1 <?php 2 2 3 3 abstract class CelerityManagementWorkflow 4 - extends PhabricatorManagementWorkflow { 5 - 6 - } 4 + extends PhabricatorManagementWorkflow {}
+1 -3
src/infrastructure/customfield/exception/PhabricatorCustomFieldNotAttachedException.php
··· 1 1 <?php 2 2 3 3 final class PhabricatorCustomFieldNotAttachedException 4 - extends Exception { 5 - 6 - } 4 + extends Exception {}
+1 -3
src/infrastructure/daemon/workers/exception/PhabricatorWorkerPermanentFailureException.php
··· 1 1 <?php 2 2 3 - final class PhabricatorWorkerPermanentFailureException extends Exception { 4 - 5 - } 3 + final class PhabricatorWorkerPermanentFailureException extends Exception {}
+1 -3
src/infrastructure/edges/constants/PhabricatorEdgeConstants.php
··· 1 1 <?php 2 2 3 - abstract class PhabricatorEdgeConstants { 4 - 5 - } 3 + abstract class PhabricatorEdgeConstants {}
+1 -3
src/infrastructure/events/PhabricatorAutoEventListener.php
··· 12 12 * startup. This allows it to be used with custom one-offs that can be dropped 13 13 * into `phabricator/src/extensions/`. 14 14 */ 15 - abstract class PhabricatorAutoEventListener extends PhabricatorEventListener { 16 - 17 - } 15 + abstract class PhabricatorAutoEventListener extends PhabricatorEventListener {}
+1 -3
src/infrastructure/internationalization/management/PhabricatorInternationalizationManagementWorkflow.php
··· 1 1 <?php 2 2 3 3 abstract class PhabricatorInternationalizationManagementWorkflow 4 - extends PhabricatorManagementWorkflow { 5 - 6 - } 4 + extends PhabricatorManagementWorkflow {}
+1 -3
src/infrastructure/query/PhabricatorEmptyQueryException.php
··· 1 1 <?php 2 2 3 - final class PhabricatorEmptyQueryException extends Exception { 4 - 5 - } 3 + final class PhabricatorEmptyQueryException extends Exception {}
+1 -3
src/infrastructure/sms/management/PhabricatorSMSManagementWorkflow.php
··· 1 1 <?php 2 2 3 3 abstract class PhabricatorSMSManagementWorkflow 4 - extends PhabricatorManagementWorkflow { 5 - 6 - } 4 + extends PhabricatorManagementWorkflow {}
+1 -1
src/infrastructure/storage/lisk/__tests__/LiskIsolationTestDAOException.php
··· 1 1 <?php 2 2 3 - final class LiskIsolationTestDAOException extends Exception { } 3 + final class LiskIsolationTestDAOException extends Exception {}
+1 -3
src/infrastructure/util/password/PhabricatorPasswordHasherUnavailableException.php
··· 1 1 <?php 2 2 3 - final class PhabricatorPasswordHasherUnavailableException extends Exception { 4 - 5 - } 3 + final class PhabricatorPasswordHasherUnavailableException extends Exception {}