@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Revert use of "user-select: all" to modify tab selection behavior
Summary:
Reverts D21419. See PHI1814. Previously, I used "user-select: all" to group sequences of spaces for selection.
However, this has a side effect: the sequence is now selected with a single click. I didn't read the docuementation on the CSS property thoroughly and missed this in testing, since I was focused on drag-selection behavior.
This behavior is enough of a net negative that I think we're in a worse state overall; revert it.
Test Plan: Straight revert.
Differential Revision: https://secure.phabricator.com/D21429
+8
-20
+6
-6
resources/celerity/map.php
+6
-6
resources/celerity/map.php
···
9
9
'names' => array(
10
10
'conpherence.pkg.css' => '0e3cf785',
11
11
'conpherence.pkg.js' => '020aebcf',
12
-
'core.pkg.css' => '2e175364',
12
+
'core.pkg.css' => 'da792a0f',
13
13
'core.pkg.js' => '845355f4',
14
14
'dark-console.pkg.js' => '187792c2',
15
15
'differential.pkg.css' => '5c459f92',
···
115
115
'rsrc/css/application/uiexample/example.css' => 'b4795059',
116
116
'rsrc/css/core/core.css' => '1b29ed61',
117
117
'rsrc/css/core/remarkup.css' => '7d3ebc86',
118
-
'rsrc/css/core/syntax.css' => '98fdb17e',
118
+
'rsrc/css/core/syntax.css' => '548567f6',
119
119
'rsrc/css/core/z-index.css' => 'ac3bfcd4',
120
120
'rsrc/css/diviner/diviner-shared.css' => '4bd263b0',
121
121
'rsrc/css/font/font-awesome.css' => '3883938a',
···
909
909
'sprite-login-css' => '18b368a6',
910
910
'sprite-tokens-css' => 'f1896dc5',
911
911
'syntax-default-css' => '055fc231',
912
-
'syntax-highlighting-css' => '98fdb17e',
912
+
'syntax-highlighting-css' => '548567f6',
913
913
'tokens-css' => 'ce5a50bd',
914
914
'trigger-rule' => '41b7b4f6',
915
915
'trigger-rule-control' => '5faf27b9',
···
1422
1422
'phuix-autocomplete',
1423
1423
'javelin-mask',
1424
1424
),
1425
+
'548567f6' => array(
1426
+
'syntax-default-css',
1427
+
),
1425
1428
'55a24e84' => array(
1426
1429
'javelin-install',
1427
1430
'javelin-dom',
···
1799
1802
'javelin-dom',
1800
1803
'javelin-request',
1801
1804
'javelin-util',
1802
-
),
1803
-
'98fdb17e' => array(
1804
-
'syntax-default-css',
1805
1805
),
1806
1806
'995f5102' => array(
1807
1807
'javelin-install',
-7
src/applications/differential/parser/DifferentialChangesetParser.php
-7
src/applications/differential/parser/DifferentialChangesetParser.php
···
1604
1604
'span',
1605
1605
array(
1606
1606
'data-copy-text' => "\t",
1607
-
1608
-
// See PHI1814. Mark this as a single logical tab for the purposes
1609
-
// of text selection behavior: when the user drags their mouse over
1610
-
// the character sequence, we'd like the whole thing to select as
1611
-
// a single unit.
1612
-
1613
-
'class' => 'logical-tab',
1614
1607
),
1615
1608
str_repeat(' ', $ii));
1616
1609
$tag = phutil_string_cast($tag);
+2
-2
src/applications/differential/parser/__tests__/DifferentialTabReplacementTestCase.php
+2
-2
src/applications/differential/parser/__tests__/DifferentialTabReplacementTestCase.php
···
4
4
extends PhabricatorTestCase {
5
5
6
6
public function testTabReplacement() {
7
-
$tab1 = "<span data-copy-text=\"\t\" class=\"logical-tab\"> </span>";
8
-
$tab2 = "<span data-copy-text=\"\t\" class=\"logical-tab\"> </span>";
7
+
$tab1 = "<span data-copy-text=\"\t\"> </span>";
8
+
$tab2 = "<span data-copy-text=\"\t\"> </span>";
9
9
10
10
$cat = "\xF0\x9F\x90\xB1";
11
11