recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix a CalendarExport issue when an existing export has an unsupported mode

Summary:
See D16676. When an export has an unsupported mode (bad database value, out-of-date object, etc) the intent of this code is to put it into the `<select />` so that you can save the form without silently changing the object.

However, it incorrectly calls `array_shift()` instead of `array_unshift()`.

Test Plan:
Edited a Calendar export with an invalid mode, saw the mode appear properly in the dropdown:

{F2957321}

Reviewers: vrana, chad

Reviewed By: vrana

Differential Revision: https://secure.phabricator.com/D17369

epriestley 01f277ce e0cd3062

+1 -1
+1 -1
src/applications/calendar/editor/PhabricatorCalendarExportEditEngine.php
··· 70 70 71 71 $current_mode = $object->getPolicyMode(); 72 72 if (empty($export_modes[$current_mode])) { 73 - array_shift($export_modes, $current_mode); 73 + array_unshift($export_modes, $current_mode); 74 74 } 75 75 76 76 $mode_options = array();