recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix username typeahead in Remarkup with German keyboard layout

Summary:
Ref T10252. The previous fix rPa8a9fddb0738 only works for macOS.
Under Windows the @ symbol is composed of AltGr+q. For Chrome and Edge the "AltGr" keypressEvent is like pressing the Control key and the Alt key at the same time.
This fix changes the condition in such a way, that this case (pressing Control and Alt at the same time) is not blocked.

Test Plan:
Testing for the issue:

- Launch Windows 10, Select German Keyboard, Use latest Chrome (60)
- Observe typing `@` does not trigger typeahead
- Apply patch, retest, see typeahead.

Regression tested:

- Windows 10, Chrome, Firefox, Edge
- Mac OS, Chrome, Firefox, Safari
- Keyboard layouts, English, French, German, Spanish

All tests passed

Reviewers: benwick, epriestley

Reviewed By: epriestley

Subscribers: epriestley

Maniphest Tasks: T10252

Differential Revision: https://secure.phabricator.com/D18269

Chad Little 020f3c72 cfb86ddd

+9 -9
+8 -8
resources/celerity/map.php
··· 528 528 'rsrc/js/phui/behavior-phui-tab-group.js' => '0a0b10e9', 529 529 'rsrc/js/phuix/PHUIXActionListView.js' => 'b5c256b8', 530 530 'rsrc/js/phuix/PHUIXActionView.js' => '442efd08', 531 - 'rsrc/js/phuix/PHUIXAutocomplete.js' => 'f6699267', 531 + 'rsrc/js/phuix/PHUIXAutocomplete.js' => '4b7430ab', 532 532 'rsrc/js/phuix/PHUIXButtonView.js' => 'a37126bd', 533 533 'rsrc/js/phuix/PHUIXDropdownMenu.js' => '8018ee50', 534 534 'rsrc/js/phuix/PHUIXExample.js' => '68af71ca', ··· 881 881 'phui-workpanel-view-css' => 'a3a63478', 882 882 'phuix-action-list-view' => 'b5c256b8', 883 883 'phuix-action-view' => '442efd08', 884 - 'phuix-autocomplete' => 'f6699267', 884 + 'phuix-autocomplete' => '4b7430ab', 885 885 'phuix-button-view' => 'a37126bd', 886 886 'phuix-dropdown-menu' => '8018ee50', 887 887 'phuix-form-control-view' => '83e03671', ··· 1236 1236 'javelin-dom', 1237 1237 'javelin-util', 1238 1238 'phabricator-shaped-request', 1239 + ), 1240 + '4b7430ab' => array( 1241 + 'javelin-install', 1242 + 'javelin-dom', 1243 + 'phuix-icon-view', 1244 + 'phabricator-prefab', 1239 1245 ), 1240 1246 '4c193c96' => array( 1241 1247 'javelin-behavior', ··· 2126 2132 'javelin-reactornode', 2127 2133 'javelin-util', 2128 2134 'javelin-reactor', 2129 - ), 2130 - 'f6699267' => array( 2131 - 'javelin-install', 2132 - 'javelin-dom', 2133 - 'phuix-icon-view', 2134 - 'phabricator-prefab', 2135 2135 ), 2136 2136 'f7fc67ec' => array( 2137 2137 'javelin-install',
+1 -1
webroot/rsrc/js/phuix/PHUIXAutocomplete.js
··· 199 199 // to press Alt to type characters like "@" on a German keyboard layout. 200 200 // The cost of misfiring autocompleters is very small since we do not 201 201 // eat the keystroke. See T10252. 202 - if (r.metaKey || r.ctrlKey) { 202 + if (r.metaKey || (r.ctrlKey && !r.altKey)) { 203 203 return; 204 204 } 205 205