@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Move Conpherence to "Z" monogram instead of "E"
Summary:
Ref T7439. Fixes T7438. This is only used in email right now.
Remain backward compatible.
Test Plan:
- Sent a message, saw a "Z" reply address.
- Checked the PHIDType.
- Grepped for `"E"` and `'E'`.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T7439, T7438
Differential Revision: https://secure.phabricator.com/D11956
+6
-4
+2
-2
src/applications/conpherence/mail/ConpherenceReplyHandler.php
+2
-2
src/applications/conpherence/mail/ConpherenceReplyHandler.php
···
20
20
21
21
public function getPrivateReplyHandlerEmailAddress(
22
22
PhabricatorObjectHandle $handle) {
23
-
return $this->getDefaultPrivateReplyHandlerEmailAddress($handle, 'E');
23
+
return $this->getDefaultPrivateReplyHandlerEmailAddress($handle, 'Z');
24
24
}
25
25
26
26
public function getPublicReplyHandlerEmailAddress() {
27
-
return $this->getDefaultPublicReplyHandlerEmailAddress('E');
27
+
return $this->getDefaultPublicReplyHandlerEmailAddress('Z');
28
28
}
29
29
30
30
public function getReplyHandlerInstructions() {
+4
-2
src/applications/conpherence/mail/ConpherenceThreadMailReceiver.php
+4
-2
src/applications/conpherence/mail/ConpherenceThreadMailReceiver.php
···
9
9
}
10
10
11
11
protected function getObjectPattern() {
12
-
return 'E[1-9]\d*';
12
+
// TODO: Only recognize "Z" once we get closer to shipping Calendar.
13
+
return '[EZ][1-9]\d*';
13
14
}
14
15
15
16
protected function loadObject($pattern, PhabricatorUser $viewer) {
16
-
$id = (int)trim($pattern, 'E');
17
+
// TODO: Only recognize "Z" once we get closer to shipping Calendar.
18
+
$id = (int)trim($pattern, 'EZ');
17
19
18
20
return id(new ConpherenceThreadQuery())
19
21
->setViewer($viewer)