@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove all application callers to "putInSet()"
Summary: Ref T13218. This is the last public-facing API call for `loadRelatives/loadOneRelative`. This just "primed" objects to make the other calls work and had no direct effects.
Test Plan:
- Ran `bin/fact analyze`.
- Used `bin/storage upgrade -f --apply` to apply `20181031.board.01.queryreset.php`, which uses `LiskMigrationIterator`.
- Browsed user list.
Reviewers: amckinley
Reviewed By: amckinley
Subscribers: yelirekim
Maniphest Tasks: T13218
Differential Revision: https://secure.phabricator.com/D19878
+5
-19
+1
-6
src/applications/fact/extract/PhabricatorFactUpdateIterator.php
+1
-6
src/applications/fact/extract/PhabricatorFactUpdateIterator.php
···
12
12
private $position;
13
13
private $ignoreUpdatesDuration = 15;
14
14
15
-
private $set;
16
-
17
15
public function __construct(LiskDAO $object) {
18
-
$this->set = new LiskDAOSet();
19
-
$this->object = $object->putInSet($this->set);
16
+
$this->object = $object;
20
17
}
21
18
22
19
public function setPosition($position) {
···
41
38
}
42
39
43
40
protected function loadPage() {
44
-
$this->set->clearSet();
45
-
46
41
if ($this->object->hasProperty('dateModified')) {
47
42
if ($this->cursor) {
48
43
list($after_epoch, $after_id) = explode(':', $this->cursor);
+1
-8
src/applications/people/query/PhabricatorPeopleQuery.php
+1
-8
src/applications/people/query/PhabricatorPeopleQuery.php
···
163
163
}
164
164
165
165
protected function loadPage() {
166
-
$table = new PhabricatorUser();
167
-
$data = $this->loadStandardPageRows($table);
168
-
169
-
if ($this->needPrimaryEmail) {
170
-
$table->putInSet(new LiskDAOSet());
171
-
}
172
-
173
-
return $table->loadAllFromArray($data);
166
+
return $this->loadStandardPage($this->newResultObject());
174
167
}
175
168
176
169
protected function didFilterPage(array $users) {
+3
-5
src/infrastructure/storage/lisk/LiskMigrationIterator.php
+3
-5
src/infrastructure/storage/lisk/LiskMigrationIterator.php
···
17
17
18
18
private $object;
19
19
private $cursor;
20
-
private $set;
21
20
22
21
public function __construct(LiskDAO $object) {
23
-
$this->set = new LiskDAOSet();
24
-
$this->object = $object->putInSet($this->set);
22
+
$this->object = $object;
25
23
}
26
24
27
25
protected function didRewind() {
···
33
31
}
34
32
35
33
protected function loadPage() {
36
-
$this->set->clearSet();
37
-
38
34
$results = $this->object->loadAllWhere(
39
35
'id > %d ORDER BY id ASC LIMIT %d',
40
36
$this->cursor,
41
37
$this->getPageSize());
38
+
42
39
if ($results) {
43
40
$this->cursor = last($results)->getID();
44
41
}
42
+
45
43
return $results;
46
44
}
47
45