@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
When there are no setup issues, don't show a weird empty box
Summary: Ref T13189. When there are no setup issues, we currently double-render a weird setup issues box underneath the notice. Get rid of it.
Test Plan: Viewed page with and without setup issues, saw less awkward UI.
Reviewers: amckinley
Maniphest Tasks: T13189
Differential Revision: https://secure.phabricator.com/D19609
+15
-19
+15
-19
src/applications/config/controller/PhabricatorConfigIssueListController.php
+15
-19
src/applications/config/controller/PhabricatorConfigIssueListController.php
···
33
33
PhabricatorSetupCheck::GROUP_OTHER,
34
34
'fa-question-circle');
35
35
36
-
$no_issues = null;
37
-
if (empty($issues)) {
38
-
$no_issues = id(new PHUIInfoView())
36
+
$title = pht('Setup Issues');
37
+
$header = $this->buildHeaderView($title);
38
+
39
+
if (!$issues) {
40
+
$issue_list = id(new PHUIInfoView())
39
41
->setTitle(pht('No Issues'))
40
42
->appendChild(
41
43
pht('Your install has no current setup issues to resolve.'))
42
44
->setSeverity(PHUIInfoView::SEVERITY_NOTICE);
43
-
}
44
-
45
-
$title = pht('Setup Issues');
46
-
$header = $this->buildHeaderView($title);
47
-
48
-
$issue_list = array(
49
-
$important,
50
-
$php,
51
-
$mysql,
52
-
$other,
53
-
);
45
+
} else {
46
+
$issue_list = array(
47
+
$important,
48
+
$php,
49
+
$mysql,
50
+
$other,
51
+
);
54
52
55
-
$issue_list = $this->buildConfigBoxView(pht('Issues'), $issue_list);
53
+
$issue_list = $this->buildConfigBoxView(pht('Issues'), $issue_list);
54
+
}
56
55
57
56
$crumbs = $this->buildApplicationCrumbs()
58
57
->addTextCrumb($title)
···
62
61
->setHeader($header)
63
62
->setNavigation($nav)
64
63
->setFixed(true)
65
-
->setMainColumn(array(
66
-
$no_issues,
67
-
$issue_list,
68
-
));
64
+
->setMainColumn($issue_list);
69
65
70
66
return $this->newPage()
71
67
->setTitle($title)