recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix Maniphest fatal if attached tasks are not an array

Summary: Fixes T3678. I think some very old rows may have a junk value here. This will be obsoleted by ApplicationTransactions and other modernization, most likely, so just fix it locally.

Test Plan: looked at a task

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3678

Differential Revision: https://secure.phabricator.com/D6677

epriestley 02ccca4b 3fd2c0ff

+4
+4
src/applications/maniphest/controller/ManiphestTaskDetailController.php
··· 566 566 } 567 567 568 568 $attached = $task->getAttached(); 569 + if (!is_array($attached)) { 570 + $attached = array(); 571 + } 572 + 569 573 $file_infos = idx($attached, PhabricatorFilePHIDTypeFile::TYPECONST); 570 574 if ($file_infos) { 571 575 $file_phids = array_keys($file_infos);