-1

scripts/celerity_mapper.php

reviewed

··· 161 161 ), 162 162 'maniphest.pkg.css' => array( 163 163 'maniphest-task-summary-css', 164 164 - 'maniphest-transaction-detail-css', 165 164 'phabricator-project-tag-css', 166 165 ), 167 166 'maniphest.pkg.js' => array(

+5 -16

src/__celerity_resource_map__.php

reviewed

··· 2924 2924 ), 2925 2925 'disk' => '/rsrc/css/application/maniphest/task-summary.css', 2926 2926 ), 2927 2927 - 'maniphest-transaction-detail-css' => 2928 2928 - array( 2929 2929 - 'uri' => '/res/f2c9582c/rsrc/css/application/maniphest/transaction-detail.css', 2930 2930 - 'type' => 'css', 2931 2931 - 'requires' => 2932 2932 - array( 2933 2933 - ), 2934 2934 - 'disk' => '/rsrc/css/application/maniphest/transaction-detail.css', 2935 2935 - ), 2936 2927 'multirow-row-manager' => 2937 2928 array( 2938 2929 'uri' => '/res/408fae4f/rsrc/js/core/MultirowRowManager.js', ··· 4380 4371 'uri' => '/res/pkg/9564fa17/javelin.pkg.js', 4381 4372 'type' => 'js', 4382 4373 ), 4383 4383 - '36d5d071' => 4374 4374 + 49898640 => 4384 4375 array( 4385 4376 'name' => 'maniphest.pkg.css', 4386 4377 'symbols' => 4387 4378 array( 4388 4379 0 => 'maniphest-task-summary-css', 4389 4389 - 1 => 'maniphest-transaction-detail-css', 4390 4390 - 2 => 'phabricator-project-tag-css', 4380 4380 + 1 => 'phabricator-project-tag-css', 4391 4381 ), 4392 4392 - 'uri' => '/res/pkg/36d5d071/maniphest.pkg.css', 4382 4382 + 'uri' => '/res/pkg/49898640/maniphest.pkg.css', 4393 4383 'type' => 'css', 4394 4384 ), 4395 4385 '83a3853e' => ··· 4505 4495 'javelin-vector' => '9564fa17', 4506 4496 'javelin-workflow' => '9564fa17', 4507 4497 'lightbox-attachment-css' => 'b1d5e69b', 4508 4508 - 'maniphest-task-summary-css' => '36d5d071', 4509 4509 - 'maniphest-transaction-detail-css' => '36d5d071', 4498 4498 + 'maniphest-task-summary-css' => '49898640', 4510 4499 'phabricator-action-list-view-css' => 'b1d5e69b', 4511 4500 'phabricator-application-launch-view-css' => 'b1d5e69b', 4512 4501 'phabricator-busy' => '8977e356', ··· 4531 4520 'phabricator-object-selector-css' => '44bfe40c', 4532 4521 'phabricator-phtize' => '8977e356', 4533 4522 'phabricator-prefab' => '8977e356', 4534 4534 - 'phabricator-project-tag-css' => '36d5d071', 4523 4523 + 'phabricator-project-tag-css' => '49898640', 4535 4524 'phabricator-property-list-view-css' => 'b1d5e69b', 4536 4525 'phabricator-remarkup-css' => 'b1d5e69b', 4537 4526 'phabricator-shaped-request' => '5e9e5c4e',

-2

src/__phutil_library_map__.php

reviewed

··· 734 734 'ManiphestTaskSubscriber' => 'applications/maniphest/storage/ManiphestTaskSubscriber.php', 735 735 'ManiphestTransaction' => 'applications/maniphest/storage/ManiphestTransaction.php', 736 736 'ManiphestTransactionComment' => 'applications/maniphest/storage/ManiphestTransactionComment.php', 737 737 - 'ManiphestTransactionDetailView' => 'applications/maniphest/view/ManiphestTransactionDetailView.php', 738 737 'ManiphestTransactionEditor' => 'applications/maniphest/editor/ManiphestTransactionEditor.php', 739 738 'ManiphestTransactionPreviewController' => 'applications/maniphest/controller/ManiphestTransactionPreviewController.php', 740 739 'ManiphestTransactionPro' => 'applications/maniphest/storage/ManiphestTransactionPro.php', ··· 2826 2825 'ManiphestTaskSubscriber' => 'ManiphestDAO', 2827 2826 'ManiphestTransaction' => 'PhabricatorMarkupInterface', 2828 2827 'ManiphestTransactionComment' => 'PhabricatorApplicationTransactionComment', 2829 2829 - 'ManiphestTransactionDetailView' => 'ManiphestView', 2830 2828 'ManiphestTransactionEditor' => 'PhabricatorEditor', 2831 2829 'ManiphestTransactionPreviewController' => 'ManiphestController', 2832 2830 'ManiphestTransactionPro' => 'PhabricatorApplicationTransaction',

-789

src/applications/maniphest/view/ManiphestTransactionDetailView.php

reviewed

··· 1 1 - <?php 2 2 - 3 3 - /** 4 4 - * @group maniphest 5 5 - */ 6 6 - final class ManiphestTransactionDetailView extends ManiphestView { 7 7 - 8 8 - private $transactions; 9 9 - private $handles; 10 10 - private $markupEngine; 11 11 - private $forEmail; 12 12 - private $preview; 13 13 - private $commentNumber; 14 14 - 15 15 - private $auxiliaryFields; 16 16 - 17 17 - public function setAuxiliaryFields(array $fields) { 18 18 - assert_instances_of($fields, 'ManiphestCustomField'); 19 19 - $this->auxiliaryFields = mpull($fields, null, 'getFieldKey'); 20 20 - return $this; 21 21 - } 22 22 - 23 23 - public function getAuxiliaryField($key) { 24 24 - return idx($this->auxiliaryFields, $key); 25 25 - } 26 26 - 27 27 - public function setTransactionGroup(array $transactions) { 28 28 - assert_instances_of($transactions, 'ManiphestTransaction'); 29 29 - $this->transactions = $transactions; 30 30 - return $this; 31 31 - } 32 32 - 33 33 - public function setHandles(array $handles) { 34 34 - assert_instances_of($handles, 'PhabricatorObjectHandle'); 35 35 - $this->handles = $handles; 36 36 - return $this; 37 37 - } 38 38 - 39 39 - public function setMarkupEngine(PhabricatorMarkupEngine $engine) { 40 40 - $this->markupEngine = $engine; 41 41 - return $this; 42 42 - } 43 43 - 44 44 - public function setPreview($preview) { 45 45 - $this->preview = $preview; 46 46 - return $this; 47 47 - } 48 48 - 49 49 - public function setCommentNumber($comment_number) { 50 50 - $this->commentNumber = $comment_number; 51 51 - return $this; 52 52 - } 53 53 - 54 54 - public function renderForEmail($with_date) { 55 55 - $this->forEmail = true; 56 56 - 57 57 - $transaction = reset($this->transactions); 58 58 - $author = $this->renderHandles(array($transaction->getAuthorPHID())); 59 59 - 60 60 - $action = null; 61 61 - $descs = array(); 62 62 - $comments = null; 63 63 - foreach ($this->transactions as $transaction) { 64 64 - list($verb, $desc, $classes, $full) = $this->describeAction($transaction); 65 65 - 66 66 - if ($full) { 67 67 - $desc = $full; 68 68 - } else { 69 69 - if ($desc === null) { 70 70 - continue; 71 71 - } else { 72 72 - $desc = $author.' '.$desc.'.'; 73 73 - } 74 74 - } 75 75 - 76 76 - if ($action === null) { 77 77 - $action = $verb; 78 78 - } 79 79 - 80 80 - if ($with_date) { 81 81 - // NOTE: This is going into a (potentially multi-recipient) email so 82 82 - // we can't use a single user's timezone preferences. Use the server's 83 83 - // instead, but make the timezone explicit. 84 84 - $datetime = date('M jS \a\t g:i A T', $transaction->getDateCreated()); 85 85 - $desc = "On {$datetime}, {$desc}"; 86 86 - } 87 87 - $descs[] = $desc; 88 88 - if ($transaction->hasComments()) { 89 89 - $comments = $transaction->getComments(); 90 90 - } 91 91 - } 92 92 - 93 93 - $descs = implode("\n", $descs); 94 94 - 95 95 - if ($comments) { 96 96 - $descs .= "\n".$comments; 97 97 - } 98 98 - 99 99 - foreach ($this->transactions as $transaction) { 100 100 - $supplemental = $this->renderSupplementalInfoForEmail($transaction); 101 101 - if ($supplemental) { 102 102 - $descs .= "\n\n".$supplemental; 103 103 - } 104 104 - } 105 105 - 106 106 - $this->forEmail = false; 107 107 - return array($action, $descs); 108 108 - } 109 109 - 110 110 - public function render() { 111 111 - 112 112 - if (!$this->user) { 113 113 - throw new Exception("Call setUser() before render()!"); 114 114 - } 115 115 - 116 116 - $handles = $this->handles; 117 117 - $transactions = $this->transactions; 118 118 - 119 119 - require_celerity_resource('maniphest-transaction-detail-css'); 120 120 - 121 121 - $comment_transaction = null; 122 122 - foreach ($this->transactions as $transaction) { 123 123 - if ($transaction->hasComments()) { 124 124 - $comment_transaction = $transaction; 125 125 - break; 126 126 - } 127 127 - } 128 128 - $any_transaction = reset($transactions); 129 129 - 130 130 - $author = $this->handles[$any_transaction->getAuthorPHID()]; 131 131 - 132 132 - $more_classes = array(); 133 133 - $descs = array(); 134 134 - foreach ($transactions as $transaction) { 135 135 - list($verb, $desc, $classes, $full) = $this->describeAction($transaction); 136 136 - if ($full) { 137 137 - $descs[] = javelin_tag( 138 138 - 'div', 139 139 - array( 140 140 - 'sigil' => 'maniphest-transaction-description', 141 141 - ), 142 142 - $full); 143 143 - continue; 144 144 - } 145 145 - 146 146 - if ($desc === null) { 147 147 - continue; 148 148 - } 149 149 - $more_classes = array_merge($more_classes, $classes); 150 150 - $full_summary = null; 151 151 - $descs[] = javelin_tag( 152 152 - 'div', 153 153 - array( 154 154 - 'sigil' => 'maniphest-transaction-description', 155 155 - ), 156 156 - array( 157 157 - $author->renderLink(), 158 158 - ' ', 159 159 - $desc, 160 160 - '.', 161 161 - $full_summary, 162 162 - )); 163 163 - } 164 164 - 165 165 - if ($comment_transaction && $comment_transaction->hasComments()) { 166 166 - $comment_block = $this->markupEngine->getOutput( 167 167 - $comment_transaction, 168 168 - ManiphestTransaction::MARKUP_FIELD_BODY); 169 169 - $comment_block = phutil_tag( 170 170 - 'div', 171 171 - array('class' => 'maniphest-transaction-comments phabricator-remarkup'), 172 172 - $comment_block); 173 173 - } else { 174 174 - $comment_block = null; 175 175 - } 176 176 - 177 177 - $source_transaction = nonempty($comment_transaction, $any_transaction); 178 178 - 179 179 - $xaction_view = id(new PhabricatorTransactionView()) 180 180 - ->setUser($this->user) 181 181 - ->setImageURI($author->getImageURI()) 182 182 - ->setContentSource($source_transaction->getContentSource()) 183 183 - ->setActions($descs); 184 184 - 185 185 - foreach ($more_classes as $class) { 186 186 - $xaction_view->addClass($class); 187 187 - } 188 188 - 189 189 - if ($this->preview) { 190 190 - $xaction_view->setIsPreview($this->preview); 191 191 - } else { 192 192 - $xaction_view->setEpoch($any_transaction->getDateCreated()); 193 193 - if ($this->commentNumber) { 194 194 - $anchor_name = 'comment-'.$this->commentNumber; 195 195 - $anchor_text = 196 196 - '#'.$this->commentNumber; 197 197 - 198 198 - $xaction_view->setAnchor($anchor_name, $anchor_text); 199 199 - } 200 200 - } 201 201 - 202 202 - $xaction_view->appendChild($comment_block); 203 203 - 204 204 - return $xaction_view->render(); 205 205 - } 206 206 - 207 207 - private function renderSupplementalInfoForEmail($transaction) { 208 208 - $handles = $this->handles; 209 209 - 210 210 - $type = $transaction->getTransactionType(); 211 211 - $new = $transaction->getNewValue(); 212 212 - $old = $transaction->getOldValue(); 213 213 - 214 214 - switch ($type) { 215 215 - case ManiphestTransactionType::TYPE_DESCRIPTION: 216 216 - return "NEW DESCRIPTION\n ".trim($new)."\n\n". 217 217 - "PREVIOUS DESCRIPTION\n ".trim($old); 218 218 - case ManiphestTransactionType::TYPE_ATTACH: 219 219 - $old_raw = nonempty($old, array()); 220 220 - $new_raw = nonempty($new, array()); 221 221 - 222 222 - $attach_types = array( 223 223 - DifferentialPHIDTypeRevision::TYPECONST, 224 224 - PhabricatorFilePHIDTypeFile::TYPECONST, 225 225 - ); 226 226 - 227 227 - foreach ($attach_types as $attach_type) { 228 228 - $old = array_keys(idx($old_raw, $attach_type, array())); 229 229 - $new = array_keys(idx($new_raw, $attach_type, array())); 230 230 - if ($old != $new) { 231 231 - break; 232 232 - } 233 233 - } 234 234 - 235 235 - $added = array_diff($new, $old); 236 236 - if (!$added) { 237 237 - break; 238 238 - } 239 239 - 240 240 - $links = array(); 241 241 - foreach (array_select_keys($handles, $added) as $handle) { 242 242 - $links[] = ' '.PhabricatorEnv::getProductionURI($handle->getURI()); 243 243 - } 244 244 - $links = implode("\n", $links); 245 245 - 246 246 - switch ($attach_type) { 247 247 - case DifferentialPHIDTypeRevision::TYPECONST: 248 248 - $title = 'ATTACHED REVISIONS'; 249 249 - break; 250 250 - case PhabricatorFilePHIDTypeFile::TYPECONST: 251 251 - $title = 'ATTACHED FILES'; 252 252 - break; 253 253 - } 254 254 - 255 255 - return $title."\n".$links; 256 256 - case ManiphestTransactionType::TYPE_EDGE: 257 257 - $add = array_diff_key($new, $old); 258 258 - if (!$add) { 259 259 - break; 260 260 - } 261 261 - 262 262 - $links = array(); 263 263 - foreach ($add as $phid => $ignored) { 264 264 - $handle = $handles[$phid]; 265 265 - $links[] = ' '.PhabricatorEnv::getProductionURI($handle->getURI()); 266 266 - } 267 267 - $links = implode("\n", $links); 268 268 - 269 269 - $edge_type = $transaction->getMetadataValue('edge:type'); 270 270 - $title = $this->getEdgeEmailTitle($edge_type, $add); 271 271 - 272 272 - return $title."\n".$links; 273 273 - default: 274 274 - break; 275 275 - } 276 276 - 277 277 - return null; 278 278 - } 279 279 - 280 280 - private function describeAction($transaction) { 281 281 - $verb = null; 282 282 - $desc = null; 283 283 - $full = null; 284 284 - $classes = array(); 285 285 - 286 286 - $handles = $this->handles; 287 287 - 288 288 - $type = $transaction->getTransactionType(); 289 289 - $author_phid = $transaction->getAuthorPHID(); 290 290 - $new = $transaction->getNewValue(); 291 291 - $old = $transaction->getOldValue(); 292 292 - switch ($type) { 293 293 - case ManiphestTransactionType::TYPE_TITLE: 294 294 - $verb = 'Retitled'; 295 295 - $desc = 'changed the title from '.$this->renderString($old). 296 296 - ' to '.$this->renderString($new); 297 297 - break; 298 298 - case ManiphestTransactionType::TYPE_DESCRIPTION: 299 299 - $verb = 'Edited'; 300 300 - $desc = 'updated the task description'; 301 301 - break; 302 302 - case PhabricatorTransactions::TYPE_COMMENT: 303 303 - $verb = 'Commented On'; 304 304 - $desc = 'added a comment'; 305 305 - break; 306 306 - case ManiphestTransactionType::TYPE_OWNER: 307 307 - if ($transaction->getAuthorPHID() == $new) { 308 308 - $verb = 'Claimed'; 309 309 - $desc = 'claimed this task'; 310 310 - $classes[] = 'claimed'; 311 311 - } else if (!$new) { 312 312 - $verb = 'Up For Grabs'; 313 313 - $desc = 'placed this task up for grabs'; 314 314 - $classes[] = 'upforgrab'; 315 315 - } else if (!$old) { 316 316 - $verb = 'Assigned'; 317 317 - $desc = 'assigned this task to '.$this->renderHandles(array($new)); 318 318 - $classes[] = 'assigned'; 319 319 - } else { 320 320 - $verb = 'Reassigned'; 321 321 - $desc = 'reassigned this task from '. 322 322 - $this->renderHandles(array($old)). 323 323 - ' to '. 324 324 - $this->renderHandles(array($new)); 325 325 - $classes[] = 'reassigned'; 326 326 - } 327 327 - break; 328 328 - case ManiphestTransactionType::TYPE_CCS: 329 329 - $added = array_diff($new, $old); 330 330 - $removed = array_diff($old, $new); 331 331 - // can only add in preview so just show placeholder if nothing to add 332 332 - if ($this->preview && empty($added)) { 333 333 - $verb = 'Changed CC'; 334 334 - $desc = 'changed CCs..'; 335 335 - break; 336 336 - } 337 337 - if ($added && !$removed) { 338 338 - $verb = 'Added CC'; 339 339 - if (count($added) == 1) { 340 340 - $desc = 'added '.$this->renderHandles($added).' to CC'; 341 341 - } else { 342 342 - $desc = 'added CCs: '.$this->renderHandles($added); 343 343 - } 344 344 - } else if ($removed && !$added) { 345 345 - $verb = 'Removed CC'; 346 346 - if (count($removed) == 1) { 347 347 - $desc = 'removed '.$this->renderHandles($removed).' from CC'; 348 348 - } else { 349 349 - $desc = 'removed CCs: '.$this->renderHandles($removed); 350 350 - } 351 351 - } else { 352 352 - $verb = 'Changed CC'; 353 353 - $desc = 'changed CCs, added: '.$this->renderHandles($added).'; '. 354 354 - 'removed: '.$this->renderHandles($removed); 355 355 - } 356 356 - break; 357 357 - case ManiphestTransactionType::TYPE_EDGE: 358 358 - $edge_type = $transaction->getMetadataValue('edge:type'); 359 359 - 360 360 - $add = array_diff_key($new, $old); 361 361 - $rem = array_diff_key($old, $new); 362 362 - 363 363 - if ($add && !$rem) { 364 364 - $verb = $this->getEdgeAddVerb($edge_type); 365 365 - $desc = $this->getEdgeAddList($edge_type, $add); 366 366 - } else if ($rem && !$add) { 367 367 - $verb = $this->getEdgeRemVerb($edge_type); 368 368 - $desc = $this->getEdgeRemList($edge_type, $rem); 369 369 - } else { 370 370 - $verb = $this->getEdgeEditVerb($edge_type); 371 371 - $desc = $this->getEdgeEditList($edge_type, $add, $rem); 372 372 - } 373 373 - break; 374 374 - case ManiphestTransactionType::TYPE_PROJECTS: 375 375 - $added = array_diff($new, $old); 376 376 - $removed = array_diff($old, $new); 377 377 - // can only add in preview so just show placeholder if nothing to add 378 378 - if ($this->preview && empty($added)) { 379 379 - $verb = 'Changed Projects'; 380 380 - $desc = 'changed projects..'; 381 381 - break; 382 382 - } 383 383 - if ($added && !$removed) { 384 384 - $verb = 'Added Project'; 385 385 - if (count($added) == 1) { 386 386 - $desc = 'added project '.$this->renderHandles($added); 387 387 - } else { 388 388 - $desc = 'added projects: '.$this->renderHandles($added); 389 389 - } 390 390 - } else if ($removed && !$added) { 391 391 - $verb = 'Removed Project'; 392 392 - if (count($removed) == 1) { 393 393 - $desc = 'removed project '.$this->renderHandles($removed); 394 394 - } else { 395 395 - $desc = 'removed projects: '.$this->renderHandles($removed); 396 396 - } 397 397 - } else { 398 398 - $verb = 'Changed Projects'; 399 399 - $desc = 'changed projects, added: '.$this->renderHandles($added).'; '. 400 400 - 'removed: '.$this->renderHandles($removed); 401 401 - } 402 402 - break; 403 403 - case ManiphestTransactionType::TYPE_STATUS: 404 404 - if ($new == ManiphestTaskStatus::STATUS_OPEN) { 405 405 - if ($old) { 406 406 - $verb = 'Reopened'; 407 407 - $desc = 'reopened this task'; 408 408 - $classes[] = 'reopened'; 409 409 - } else { 410 410 - $verb = 'Created'; 411 411 - $desc = 'created this task'; 412 412 - $classes[] = 'created'; 413 413 - } 414 414 - } else if ($new == ManiphestTaskStatus::STATUS_CLOSED_SPITE) { 415 415 - $verb = 'Spited'; 416 416 - $desc = 'closed this task out of spite'; 417 417 - $classes[] = 'spited'; 418 418 - } else if ($new == ManiphestTaskStatus::STATUS_CLOSED_DUPLICATE) { 419 419 - $verb = 'Merged'; 420 420 - $desc = 'closed this task as a duplicate'; 421 421 - $classes[] = 'duplicate'; 422 422 - } else { 423 423 - $verb = 'Closed'; 424 424 - $full = idx(ManiphestTaskStatus::getTaskStatusMap(), $new, '???'); 425 425 - $desc = 'closed this task as "'.$full.'"'; 426 426 - $classes[] = 'closed'; 427 427 - } 428 428 - break; 429 429 - case ManiphestTransactionType::TYPE_PRIORITY: 430 430 - $old_name = ManiphestTaskPriority::getTaskPriorityName($old); 431 431 - $new_name = ManiphestTaskPriority::getTaskPriorityName($new); 432 432 - 433 433 - if ($old == ManiphestTaskPriority::getDefaultPriority()) { 434 434 - $verb = 'Triaged'; 435 435 - $desc = 'triaged this task as "'.$new_name.'" priority'; 436 436 - } else if ($old > $new) { 437 437 - $verb = 'Lowered Priority'; 438 438 - $desc = 'lowered the priority of this task from "'.$old_name.'" to '. 439 439 - '"'.$new_name.'"'; 440 440 - } else { 441 441 - $verb = 'Raised Priority'; 442 442 - $desc = 'raised the priority of this task from "'.$old_name.'" to '. 443 443 - '"'.$new_name.'"'; 444 444 - } 445 445 - break; 446 446 - case ManiphestTransactionType::TYPE_ATTACH: 447 447 - if ($this->preview) { 448 448 - $verb = 'Changed Attached'; 449 449 - $desc = 'changed attachments..'; 450 450 - break; 451 451 - } 452 452 - 453 453 - $old_raw = nonempty($old, array()); 454 454 - $new_raw = nonempty($new, array()); 455 455 - 456 456 - foreach (array( 457 457 - DifferentialPHIDTypeRevision::TYPECONST, 458 458 - ManiphestPHIDTypeTask::TYPECONST, 459 459 - PhabricatorFilePHIDTypeFile::TYPECONST) as $attach_type) { 460 460 - $old = array_keys(idx($old_raw, $attach_type, array())); 461 461 - $new = array_keys(idx($new_raw, $attach_type, array())); 462 462 - if ($old != $new) { 463 463 - break; 464 464 - } 465 465 - } 466 466 - 467 467 - $added = array_diff($new, $old); 468 468 - $removed = array_diff($old, $new); 469 469 - 470 470 - $add_desc = $this->renderHandles($added); 471 471 - $rem_desc = $this->renderHandles($removed); 472 472 - 473 473 - if ($added && !$removed) { 474 474 - $verb = 'Attached'; 475 475 - $desc = 476 476 - 'attached '. 477 477 - $this->getAttachName($attach_type, count($added)).': '. 478 478 - $add_desc; 479 479 - } else if ($removed && !$added) { 480 480 - $verb = 'Detached'; 481 481 - $desc = 482 482 - 'detached '. 483 483 - $this->getAttachName($attach_type, count($removed)).': '. 484 484 - $rem_desc; 485 485 - } else { 486 486 - $verb = 'Changed Attached'; 487 487 - $desc = 488 488 - 'changed attached '. 489 489 - $this->getAttachName($attach_type, count($added) + count($removed)). 490 490 - ', added: '.$add_desc.'; '. 491 491 - 'removed: '.$rem_desc; 492 492 - } 493 493 - break; 494 494 - case PhabricatorTransactions::TYPE_CUSTOMFIELD: 495 495 - $aux_key = $transaction->getMetadataValue('customfield:key'); 496 496 - $aux_field = idx($this->auxiliaryFields, $aux_key); 497 497 - 498 498 - if ($old === null) { 499 499 - $verb = "Set Field"; 500 500 - } else if ($new === null) { 501 501 - $verb = "Removed Field"; 502 502 - } else { 503 503 - $verb = "Updated Field"; 504 504 - } 505 505 - 506 506 - $desc = null; 507 507 - if ($aux_field) { 508 508 - $proxy_transaction = new ManiphestTransactionPro(); 509 509 - $proxy_transaction->setOldValue($transaction->getOldValue()); 510 510 - $proxy_transaction->setNewValue($transaction->getNewValue()); 511 511 - $proxy_transaction->setAuthorPHID($transaction->getAuthorPHID()); 512 512 - $proxy_transaction->setHandles($this->handles); 513 513 - 514 514 - $full = $aux_field->getApplicationTransactionTitle( 515 515 - $proxy_transaction); 516 516 - } else { 517 517 - $desc = 'updated a field'; 518 518 - } 519 519 - 520 520 - break; 521 521 - default: 522 522 - return array($type, ' brazenly '.$type."'d", $classes, null); 523 523 - } 524 524 - 525 525 - // TODO: [HTML] This code will all be rewritten when we switch to using 526 526 - // ApplicationTransactions. It does not handle HTML or translations 527 527 - // correctly right now. 528 528 - $desc = phutil_safe_html($desc); 529 529 - 530 530 - return array($verb, $desc, $classes, $full); 531 531 - } 532 532 - 533 533 - private function renderExpandLink($transaction) { 534 534 - $id = $transaction->getID(); 535 535 - 536 536 - Javelin::initBehavior('maniphest-transaction-expand'); 537 537 - 538 538 - return javelin_tag( 539 539 - 'a', 540 540 - array( 541 541 - 'href' => '/maniphest/task/descriptionchange/'.$id.'/', 542 542 - 'sigil' => 'maniphest-expand-transaction', 543 543 - 'mustcapture' => true, 544 544 - ), 545 545 - 'show details'); 546 546 - } 547 547 - 548 548 - private function renderHandles($phids, $full = false) { 549 549 - $links = array(); 550 550 - foreach ($phids as $phid) { 551 551 - if ($this->forEmail) { 552 552 - if ($full) { 553 553 - $links[] = $this->handles[$phid]->getFullName(); 554 554 - } else { 555 555 - $links[] = $this->handles[$phid]->getName(); 556 556 - } 557 557 - } else { 558 558 - $links[] = $this->handles[$phid]->renderLink(); 559 559 - } 560 560 - } 561 561 - if ($this->forEmail) { 562 562 - return implode(', ', $links); 563 563 - } else { 564 564 - return phutil_implode_html(', ', $links); 565 565 - } 566 566 - } 567 567 - 568 568 - private function renderString($string) { 569 569 - if ($this->forEmail) { 570 570 - return '"'.$string.'"'; 571 571 - } else { 572 572 - return '"'.phutil_escape_html($string).'"'; 573 573 - } 574 574 - } 575 575 - 576 576 - 577 577 - /* -( Strings )------------------------------------------------------------ */ 578 578 - 579 579 - 580 580 - /** 581 581 - * @task strings 582 582 - */ 583 583 - private function getAttachName($attach_type, $count) { 584 584 - switch ($attach_type) { 585 585 - case DifferentialPHIDTypeRevision::TYPECONST: 586 586 - return pht('Differential Revision(s)', $count); 587 587 - case PhabricatorFilePHIDTypeFile::TYPECONST: 588 588 - return pht('file(s)', $count); 589 589 - case ManiphestPHIDTypeTask::TYPECONST: 590 590 - return pht('Maniphest Task(s)', $count); 591 591 - } 592 592 - } 593 593 - 594 594 - 595 595 - /** 596 596 - * @task strings 597 597 - */ 598 598 - private function getEdgeEmailTitle($type, array $list) { 599 599 - $count = count($list); 600 600 - switch ($type) { 601 601 - case PhabricatorEdgeConfig::TYPE_TASK_HAS_RELATED_DREV: 602 602 - return pht('DIFFERENTIAL %d REVISION(S)', $count); 603 603 - case PhabricatorEdgeConfig::TYPE_TASK_DEPENDS_ON_TASK: 604 604 - return pht('DEPENDS ON %d TASK(S)', $count); 605 605 - case PhabricatorEdgeConfig::TYPE_TASK_DEPENDED_ON_BY_TASK: 606 606 - return pht('DEPENDENT %d TASK(s)', $count); 607 607 - case PhabricatorEdgeConfig::TYPE_TASK_HAS_COMMIT: 608 608 - return pht('ATTACHED %d COMMIT(S)', $count); 609 609 - case PhabricatorEdgeConfig::TYPE_TASK_HAS_MOCK: 610 610 - return pht('ATTACHED %d MOCK(S)', $count); 611 611 - default: 612 612 - return pht('ATTACHED %d OBJECT(S)', $count); 613 613 - } 614 614 - } 615 615 - 616 616 - 617 617 - /** 618 618 - * @task strings 619 619 - */ 620 620 - private function getEdgeAddVerb($type) { 621 621 - switch ($type) { 622 622 - case PhabricatorEdgeConfig::TYPE_TASK_HAS_RELATED_DREV: 623 623 - return pht('Added Revision'); 624 624 - case PhabricatorEdgeConfig::TYPE_TASK_DEPENDS_ON_TASK: 625 625 - return pht('Added Dependency'); 626 626 - case PhabricatorEdgeConfig::TYPE_TASK_DEPENDED_ON_BY_TASK: 627 627 - return pht('Added Dependent Task'); 628 628 - case PhabricatorEdgeConfig::TYPE_TASK_HAS_COMMIT: 629 629 - return pht('Added Commit'); 630 630 - case PhabricatorEdgeConfig::TYPE_TASK_HAS_MOCK: 631 631 - return pht('Added Mock'); 632 632 - default: 633 633 - return pht('Added Object'); 634 634 - } 635 635 - } 636 636 - 637 637 - 638 638 - /** 639 639 - * @task strings 640 640 - */ 641 641 - private function getEdgeRemVerb($type) { 642 642 - switch ($type) { 643 643 - case PhabricatorEdgeConfig::TYPE_TASK_HAS_RELATED_DREV: 644 644 - return pht('Removed Revision'); 645 645 - case PhabricatorEdgeConfig::TYPE_TASK_DEPENDS_ON_TASK: 646 646 - return pht('Removed Dependency'); 647 647 - case PhabricatorEdgeConfig::TYPE_TASK_DEPENDED_ON_BY_TASK: 648 648 - return pht('Removed Dependent Task'); 649 649 - case PhabricatorEdgeConfig::TYPE_TASK_HAS_COMMIT: 650 650 - return pht('Removed Commit'); 651 651 - case PhabricatorEdgeConfig::TYPE_TASK_HAS_MOCK: 652 652 - return pht('Removed Mock'); 653 653 - default: 654 654 - return pht('Removed Object'); 655 655 - } 656 656 - } 657 657 - 658 658 - 659 659 - /** 660 660 - * @task strings 661 661 - */ 662 662 - private function getEdgeEditVerb($type) { 663 663 - switch ($type) { 664 664 - case PhabricatorEdgeConfig::TYPE_TASK_HAS_RELATED_DREV: 665 665 - return pht('Changed Revisions'); 666 666 - case PhabricatorEdgeConfig::TYPE_TASK_DEPENDS_ON_TASK: 667 667 - return pht('Changed Dependencies'); 668 668 - case PhabricatorEdgeConfig::TYPE_TASK_DEPENDED_ON_BY_TASK: 669 669 - return pht('Changed Dependent Tasks'); 670 670 - case PhabricatorEdgeConfig::TYPE_TASK_HAS_COMMIT: 671 671 - return pht('Changed Commits'); 672 672 - case PhabricatorEdgeConfig::TYPE_TASK_HAS_MOCK: 673 673 - return pht('Changed Mocks'); 674 674 - default: 675 675 - return pht('Changed Objects'); 676 676 - } 677 677 - } 678 678 - 679 679 - 680 680 - /** 681 681 - * @task strings 682 682 - */ 683 683 - private function getEdgeAddList($type, array $add) { 684 684 - $list = $this->renderHandles(array_keys($add), $full = true); 685 685 - $count = count($add); 686 686 - 687 687 - switch ($type) { 688 688 - case PhabricatorEdgeConfig::TYPE_TASK_HAS_RELATED_DREV: 689 689 - return pht('added %d revision(s): %s', $count, $list); 690 690 - case PhabricatorEdgeConfig::TYPE_TASK_DEPENDS_ON_TASK: 691 691 - return pht('added %d dependencie(s): %s', $count, $list); 692 692 - case PhabricatorEdgeConfig::TYPE_TASK_DEPENDED_ON_BY_TASK: 693 693 - return pht('added %d dependent task(s): %s', $count, $list); 694 694 - case PhabricatorEdgeConfig::TYPE_TASK_HAS_COMMIT: 695 695 - return pht('added %d commit(s): %s', $count, $list); 696 696 - case PhabricatorEdgeConfig::TYPE_TASK_HAS_MOCK: 697 697 - return pht('added %d mock(s): %s', $count, $list); 698 698 - default: 699 699 - return pht('added %d object(s): %s', $count, $list); 700 700 - } 701 701 - } 702 702 - 703 703 - 704 704 - /** 705 705 - * @task strings 706 706 - */ 707 707 - private function getEdgeRemList($type, array $rem) { 708 708 - $list = $this->renderHandles(array_keys($rem), $full = true); 709 709 - $count = count($rem); 710 710 - 711 711 - switch ($type) { 712 712 - case PhabricatorEdgeConfig::TYPE_TASK_HAS_RELATED_DREV: 713 713 - return pht('removed %d revision(s): %s', $count, $list); 714 714 - case PhabricatorEdgeConfig::TYPE_TASK_DEPENDS_ON_TASK: 715 715 - return pht('removed %d dependencie(s): %s', $count, $list); 716 716 - case PhabricatorEdgeConfig::TYPE_TASK_DEPENDED_ON_BY_TASK: 717 717 - return pht('removed %d dependent task(s): %s', $count, $list); 718 718 - case PhabricatorEdgeConfig::TYPE_TASK_HAS_COMMIT: 719 719 - return pht('removed %d commit(s): %s', $count, $list); 720 720 - case PhabricatorEdgeConfig::TYPE_TASK_HAS_MOCK: 721 721 - return pht('removed %d mock(s): %s', $count, $list); 722 722 - default: 723 723 - return pht('removed %d object(s): %s', $count, $list); 724 724 - } 725 725 - } 726 726 - 727 727 - 728 728 - /** 729 729 - * @task strings 730 730 - */ 731 731 - private function getEdgeEditList($type, array $add, array $rem) { 732 732 - $add_list = $this->renderHandles(array_keys($add), $full = true); 733 733 - $rem_list = $this->renderHandles(array_keys($rem), $full = true); 734 734 - $add_count = count($add_list); 735 735 - $rem_count = count($rem_list); 736 736 - 737 737 - switch ($type) { 738 738 - case PhabricatorEdgeConfig::TYPE_TASK_HAS_RELATED_DREV: 739 739 - return pht( 740 740 - 'changed %d revision(s), added %d: %s; removed %d: %s', 741 741 - $add_count + $rem_count, 742 742 - $add_count, 743 743 - $add_list, 744 744 - $rem_count, 745 745 - $rem_list); 746 746 - case PhabricatorEdgeConfig::TYPE_TASK_DEPENDS_ON_TASK: 747 747 - return pht( 748 748 - 'changed %d dependencie(s), added %d: %s; removed %d: %s', 749 749 - $add_count + $rem_count, 750 750 - $add_count, 751 751 - $add_list, 752 752 - $rem_count, 753 753 - $rem_list); 754 754 - case PhabricatorEdgeConfig::TYPE_TASK_DEPENDED_ON_BY_TASK: 755 755 - return pht( 756 756 - 'changed %d dependent task(s), added %d: %s; removed %d: %s', 757 757 - $add_count + $rem_count, 758 758 - $add_count, 759 759 - $add_list, 760 760 - $rem_count, 761 761 - $rem_list); 762 762 - case PhabricatorEdgeConfig::TYPE_TASK_HAS_COMMIT: 763 763 - return pht( 764 764 - 'changed %d commit(s), added %d: %s; removed %d: %s', 765 765 - $add_count + $rem_count, 766 766 - $add_count, 767 767 - $add_list, 768 768 - $rem_count, 769 769 - $rem_list); 770 770 - case PhabricatorEdgeConfig::TYPE_TASK_HAS_MOCK: 771 771 - return pht( 772 772 - 'changed %d mock(s), added %d: %s; removed %d: %s', 773 773 - $add_count + $rem_count, 774 774 - $add_count, 775 775 - $add_list, 776 776 - $rem_count, 777 777 - $rem_list); 778 778 - default: 779 779 - return pht( 780 780 - 'changed %d object(s), added %d: %s; removed %d: %s', 781 781 - $add_count + $rem_count, 782 782 - $add_count, 783 783 - $add_list, 784 784 - $rem_count, 785 785 - $rem_list); 786 786 - } 787 787 - } 788 788 - 789 789 - }

-71

webroot/rsrc/css/application/maniphest/transaction-detail.css

reviewed

··· 1 1 - /** 2 2 - * @provides maniphest-transaction-detail-css 3 3 - */ 4 4 - 5 5 - .maniphest-transaction-list-view { 6 6 - padding: 0 20px; 7 7 - } 8 8 - 9 9 - .device-phone .maniphest-transaction-list-view { 10 10 - padding: 0 10px; 11 11 - } 12 12 - 13 13 - .maniphest-transaction-list-view .anchor-target { 14 14 - background-color: #ffffdd; 15 15 - border-color: #ffff00; 16 16 - } 17 17 - 18 18 - .phabricator-transaction-view .upforgrab { 19 19 - border-color: #cc9966; 20 20 - } 21 21 - 22 22 - .phabricator-transaction-view .reassigned { 23 23 - border-color: #0099aa; 24 24 - } 25 25 - 26 26 - .phabricator-transaction-view .assigned { 27 27 - border-color: #0099aa; 28 28 - } 29 29 - 30 30 - .phabricator-transaction-view .claimed { 31 31 - border-color: #0099aa; 32 32 - } 33 33 - 34 34 - .phabricator-transaction-view .created { 35 35 - border-color: #660099; 36 36 - } 37 37 - 38 38 - .phabricator-transaction-view .closed { 39 39 - border-color: #006699; 40 40 - } 41 41 - 42 42 - .phabricator-transaction-view .spited { 43 43 - border-color: #006699; 44 44 - } 45 45 - 46 46 - .phabricator-transaction-view .reopened { 47 47 - border-color: #660099; 48 48 - } 49 49 - 50 50 - .phabricator-transaction-view .duplicate { 51 51 - border-color: #333333; 52 52 - } 53 53 - 54 54 - .maniphest-change-table { 55 55 - width: 100%; 56 56 - margin: .5em 0em; 57 57 - border-collapse: separate; 58 58 - border-spacing: 4px 0px; 59 59 - } 60 60 - 61 61 - .maniphest-change-table td { 62 62 - width: 50%; 63 63 - padding: 0.25em 1em; 64 64 - background: #f9f9f9; 65 65 - } 66 66 - 67 67 - .maniphest-change-table th { 68 68 - font-weight: bold; 69 69 - padding: 0.25em; 70 70 - border-bottom: 1px solid #cccccc; 71 71 - }