@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an issue with Duo not live-updating properly on login gates
Summary:
See <https://discourse.phabricator-community.org/t/duo-broken-in-2019-week-12/2580/>.
The "live update Duo status" endpoint currently requires full sessions, and doesn't work from the session upgrade gate on login.
Don't require a full session to check the status of an MFA challenge.
Test Plan: Went through Duo gate in a new session, got a live update.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D20347
+6
+6
src/applications/auth/controller/mfa/PhabricatorAuthChallengeStatusController.php
+6
src/applications/auth/controller/mfa/PhabricatorAuthChallengeStatusController.php
···
3
3
final class PhabricatorAuthChallengeStatusController
4
4
extends PhabricatorAuthController {
5
5
6
+
public function shouldAllowPartialSessions() {
7
+
// We expect that users may request the status of an MFA challenge when
8
+
// they hit the session upgrade gate on login.
9
+
return true;
10
+
}
11
+
6
12
public function handleRequest(AphrontRequest $request) {
7
13
$viewer = $this->getViewer();
8
14
$id = $request->getURIData('id');