@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Removed unused loadGitLocalRefs() from PhabricatorRepositoryPullEngine
Summary:
rP2b0ad243d179f81baad24ccd9748a4ba59017d25 introduced `private function loadGitLocalRefs()`.
In rPe910c76e65e54a439a0af4735ae89c70076673d5, the only call to `loadGitLocalRefs()` was removed, using `loadGitRemoteRefs()` to load (and compare) both remote and local refs. Thus remove this unused method.
Test Plan: Read/grep the code in `PhabricatorRepositoryPullEngine`.
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D25718
-16
-16
src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
-16
src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
···
602
602
return $map;
603
603
}
604
604
605
-
private function loadGitLocalRefs(PhabricatorRepository $repository) {
606
-
$refs = id(new DiffusionLowLevelGitRefQuery())
607
-
->setRepository($repository)
608
-
->execute();
609
-
610
-
$map = array();
611
-
foreach ($refs as $ref) {
612
-
$fields = $ref->getRawFields();
613
-
$map[idx($fields, 'refname')] = $ref->getCommitIdentifier();
614
-
}
615
-
616
-
ksort($map);
617
-
618
-
return $map;
619
-
}
620
-
621
605
private function logRefDifferences(array $remote, array $local) {
622
606
$all = $local + $remote;
623
607