@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix missing setQuoteRef() on Commit detail pages in Diffusion
Summary: Fixes T12253.
Test Plan:
- Before change: used "Quote Comment", saw "In null, alice wrote:" in quoted text.
- After change: used "Quote Comment", saw proper reference to the commit/page. Clicked reference, was sent to the comment properly.
{F2859093}
Reviewers: chad, avivey
Reviewed By: avivey
Maniphest Tasks: T12253
Differential Revision: https://secure.phabricator.com/D17343
+4
+4
src/applications/diffusion/controller/DiffusionCommitController.php
+4
src/applications/diffusion/controller/DiffusionCommitController.php
···
705
705
$timeline = $this->buildTransactionTimeline(
706
706
$commit,
707
707
new PhabricatorAuditTransactionQuery());
708
+
708
709
$commit->willRenderTimeline($timeline, $this->getRequest());
710
+
711
+
$timeline->setQuoteRef($commit->getMonogram());
712
+
709
713
return $timeline;
710
714
}
711
715