recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

PHP 8.2: fixes for deprecated use of ${var} in strings

Summary:
Note that PHP 8.2 implemented this deprecation:

Using ${var} in strings is deprecated, use {$var} instead

This change fixes some known cases.

Ref T15196

Test Plan: - I checked with my big eyes that everything is as it should be

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: avivey, speck, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15196

Differential Revision: https://we.phorge.it/D25098

Valerio Bozzolan 03c9bf57 42a8b73a

+2 -2
+1 -1
src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php
··· 55 55 $limit = $request->getValue('limit'); 56 56 57 57 if (strlen($against_hash)) { 58 - $commit_range = "${against_hash}..${commit_hash}"; 58 + $commit_range = "{$against_hash}..{$commit_hash}"; 59 59 } else { 60 60 $commit_range = $commit_hash; 61 61 }
+1 -1
src/applications/herald/phid/HeraldTranscriptPHIDType.php
··· 35 35 $id = $xscript->getID(); 36 36 37 37 $handle->setName(pht('Transcript %s', $id)); 38 - $handle->setURI("/herald/transcript/${id}/"); 38 + $handle->setURI("/herald/transcript/$id/"); 39 39 } 40 40 } 41 41