recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Don't include resigned reviewers in the Differential "To" list

Summary: Ref T12689. See PHI178. This isn't a complete solution (you may still get mailed via packages/projects) but should fix the obvious issue, where "Resigned" reviewers are incorrectly always sent mail directly.

Test Plan: Had Alice resign, interacted as Bailey, no mail to Alice.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T12689

Differential Revision: https://secure.phabricator.com/D18758

epriestley 03d059dd 6ecdadb7

+4
+4
src/applications/differential/editor/DifferentialTransactionEditor.php
··· 630 630 $phids = array(); 631 631 $phids[] = $object->getAuthorPHID(); 632 632 foreach ($object->getReviewers() as $reviewer) { 633 + if ($reviewer->isResigned()) { 634 + continue; 635 + } 636 + 633 637 $phids[] = $reviewer->getReviewerPHID(); 634 638 } 635 639 return $phids;