@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix fatal in Conpherence NUX state
Summary: Fixes T12619.
Test Plan: Faked `return array()` in ConpherneceThreadQuery, got a NUX instead of fatal.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T12619
Differential Revision: https://secure.phabricator.com/D17764
+8
-7
+8
-7
src/applications/conpherence/controller/ConpherenceListController.php
+8
-7
src/applications/conpherence/controller/ConpherenceListController.php
···
89
89
default:
90
90
$data = $this->loadDefaultParticipation($limit);
91
91
$all_participation = $data['all_participation'];
92
-
93
-
$conpherence_id = head($all_participation)->getConpherencePHID();
94
-
$conpherence = id(new ConpherenceThreadQuery())
95
-
->setViewer($user)
96
-
->withPHIDs(array($conpherence_id))
97
-
->needProfileImage(true)
98
-
->executeOne();
92
+
if ($all_participation) {
93
+
$conpherence_id = head($all_participation)->getConpherencePHID();
94
+
$conpherence = id(new ConpherenceThreadQuery())
95
+
->setViewer($user)
96
+
->withPHIDs(array($conpherence_id))
97
+
->needProfileImage(true)
98
+
->executeOne();
99
+
}
99
100
// If $conpherence is null, NUX state will render
100
101
break;
101
102
}