recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix config-migration text for dashboard options

Summary:
The commit which added checks for the old homepage options (now in
Dashboard) in rP9d9a47e9cf, added them to the auth section, where they
would present:
This option has been migrated to the "Auth" application. Your old
configuration is still in effect, but now stored in "Auth" instead of
configuration. Going forward, you can manage authentication from the
web UI.

Remove them from the moved-to-Auth list, and coalesce the multiple
definitions of the help text into one.

Test Plan:
- set maniphest.priorities.unbreak-now to something
- observe the setup issue reported
- hope it tells you the right thing

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley, chad

Differential Revision: https://secure.phabricator.com/D16576

authored by

Daniel Stone and committed by
fooishbar 03d323e9 51f8ec44

+7 -14
+7 -14
src/applications/config/check/PhabricatorExtraConfigSetupCheck.php
··· 143 143 'phabricator.auth-permanent', 144 144 'phabricator.application-id', 145 145 'phabricator.application-secret', 146 - 'maniphest.priorities.unbreak-now', 147 - 'maniphest.priorities.needs-triage', 148 - 'welcome.html', 149 146 ); 150 147 151 148 $ancient_config = array_fill_keys($auth_config, $reason_auth); ··· 196 193 $global_settings_reason = pht( 197 194 'The "Re: Prefix" and "Vary Subjects" settings are now configured '. 198 195 'in global settings.'); 196 + 197 + $dashboard_reason = pht( 198 + 'This option has been removed, you can use Dashboards to provide '. 199 + 'homepage customization. See T11533 for more details.'); 199 200 200 201 $ancient_config += array( 201 202 'phid.external-loaders' => ··· 336 337 'This option has been replaced with `ui.logo`, which provides more '. 337 338 'flexible configuration options.'), 338 339 339 - 'welcome.html' => pht( 340 - 'This option has been removed, you can use Dashboards to provide '. 341 - 'homepage customization. See T11533 for more details.'), 342 - 343 - 'maniphest.priorities.unbreak-now' => pht( 344 - 'This option has been removed, you can use Dashboards to provide '. 345 - 'homepage customization. See T11533 for more details.'), 346 - 347 - 'maniphest.priorities.needs-triage' => pht( 348 - 'This option has been removed, you can use Dashboards to provide '. 349 - 'homepage customization. See T11533 for more details.'), 340 + 'welcome.html' => $dashboard_reason, 341 + 'maniphest.priorities.unbreak-now' => $dashboard_reason, 342 + 'maniphest.priorities.needs-triage' => $dashboard_reason, 350 343 351 344 ); 352 345