@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add slug check around project.query conduit call
Summary: Fixes T6252
Test Plan: Test project query from conduit app, see no errors in log.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T6252
Differential Revision: https://secure.phabricator.com/D10655
+8
-6
+8
-6
src/applications/project/conduit/ProjectQueryConduitAPIMethod.php
+8
-6
src/applications/project/conduit/ProjectQueryConduitAPIMethod.php
···
24
24
25
25
return array(
26
26
'ids' => 'optional list<int>',
27
-
'names' => 'optional list<string>',
27
+
'names' => 'optional list<string>',
28
28
'phids' => 'optional list<phid>',
29
29
'slugs' => 'optional list<string>',
30
30
'status' => 'optional '.$status_const,
···
96
96
97
97
// TODO: This is pretty hideous.
98
98
$slug_map = array();
99
-
foreach ($slugs as $slug) {
100
-
$normal = rtrim(PhabricatorSlug::normalize($slug), '/');
101
-
foreach ($projects as $project) {
102
-
if (in_array($normal, $project['slugs'])) {
103
-
$slug_map[$slug] = $project['phid'];
99
+
if ($slugs) {
100
+
foreach ($slugs as $slug) {
101
+
$normal = rtrim(PhabricatorSlug::normalize($slug), '/');
102
+
foreach ($projects as $project) {
103
+
if (in_array($normal, $project['slugs'])) {
104
+
$slug_map[$slug] = $project['phid'];
105
+
}
104
106
}
105
107
}
106
108
}