@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Render object remarkup references in a text context as "Dxxx <uri>"
Summary:
Depends on D19031. Fixes T11389. Currently, we render `Dxxx` in a text context (plain text email) as just a URI.
Instead, render it like `Dxxx <uri>`. This is more faithful to the original intent and preserves `T123/T456` as two separate, usable links.
Test Plan: Wrote `T123/T234` in a task, pulled mail for it with `bin/mail show-outbound`, saw separate clickable links.
Maniphest Tasks: T11389
Differential Revision: https://secure.phabricator.com/D19032
+1
-1
+1
-1
src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php
+1
-1
src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php
···
75
75
}
76
76
77
77
if ($this->getEngine()->isTextMode()) {
78
-
return PhabricatorEnv::getProductionURI($href);
78
+
return $text.' <'.PhabricatorEnv::getProductionURI($href).'>';
79
79
} else if ($this->getEngine()->isHTMLMailMode()) {
80
80
$href = PhabricatorEnv::getProductionURI($href);
81
81
return $this->renderObjectTagForMail($text, $href, $handle);