recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix issue where "phabricator" disqus account is used by default and not overridable

Summary: Currently setting "disqus.shortname" via config isn't actually used in the instantiation of disqus. This fix uses the shortname configured.

Test Plan: Open a phame post with disqus enabled and a shortname other than "phabricator" specified.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D6310

authored by

Cam Spiers and committed by
epriestley 0495eb15 78311f75

+2 -1
+2 -1
src/applications/phame/view/PhamePostView.php
··· 212 212 // protip - try some var disqus_developer = 1; action to test locally 213 213 $disqus_js = CelerityStaticResourceResponse::renderInlineScript( 214 214 jsprintf( 215 - ' var disqus_shortname = "phabricator";'. 215 + ' var disqus_shortname = %s;'. 216 216 ' var disqus_identifier = %s;'. 217 217 ' var disqus_url = %s;'. 218 218 ' var disqus_title = %s;'. ··· 224 224 '(document.getElementsByTagName("head")[0] ||'. 225 225 ' document.getElementsByTagName("body")[0]).appendChild(dsq);'. 226 226 '})();', 227 + $disqus_shortname, 227 228 $post->getPHID(), 228 229 $this->getSkin()->getURI('post/'.$this->getPost()->getPhameTitle()), 229 230 $post->getTitle()));