@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Improve /auth/ behavior when a provider implementation is missing
Summary: Ref T1536. This "should never happen", but can if you're developing custom providers. Improve the robustness of this interface in the presence of missing provider implementations.
Test Plan: {F47008}
Reviewers: chad, btrahan
Reviewed By: chad
CC: aran
Maniphest Tasks: T1536
Differential Revision: https://secure.phabricator.com/D6253
+14
-6
+14
-6
src/applications/auth/controller/config/PhabricatorAuthListController.php
+14
-6
src/applications/auth/controller/config/PhabricatorAuthListController.php
···
25
25
if ($provider) {
26
26
$name = $provider->getProviderName();
27
27
} else {
28
-
$name = $config->getProviderType();
28
+
$name = $config->getProviderType().' ('.$config->getProviderClass().')';
29
29
}
30
30
31
31
$item
32
-
->setHeader($name)
33
-
->setHref($edit_uri);
32
+
->setHeader($name);
34
33
35
-
$domain = $provider->getProviderDomain();
36
-
if ($domain !== 'self') {
37
-
$item->addAttribute($domain);
34
+
if ($provider) {
35
+
$item->setHref($edit_uri);
36
+
} else {
37
+
$item->addAttribute(pht('Provider Implementation Missing!'));
38
+
}
39
+
40
+
$domain = null;
41
+
if ($provider) {
42
+
$domain = $provider->getProviderDomain();
43
+
if ($domain !== 'self') {
44
+
$item->addAttribute($domain);
45
+
}
38
46
}
39
47
40
48
if ($config->getShouldAllowRegistration()) {