@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
In "Move task to..." workflow, separate visible and hidden columns in the dropdown
Summary:
Ref T13368. Currently, both visible and hidden columns are shown in the "Move tasks to..." dropdown on workflows from workboards.
When the dropdown contains hidden columns, move them to a separate section to make it clear that they're not likely targets.
Test Plan:
- Used "Move tasks to project..." targeting a board with no hidden columns. Saw a single ungrouped dropdown.
- Used "Move tasks to project..." targeting a board with hidden columns. Saw a dropdown grouped into "Visible" and "Hidden" columns.
Maniphest Tasks: T13368
Differential Revision: https://secure.phabricator.com/D20700
+33
-5
+33
-5
src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php
+33
-5
src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php
···
219
219
->setValue($dst_project->getDisplayName()));
220
220
}
221
221
222
+
$column_options = array(
223
+
'visible' => array(),
224
+
'hidden' => array(),
225
+
);
226
+
227
+
$any_hidden = false;
228
+
foreach ($dst_columns as $column) {
229
+
if (!$column->isHidden()) {
230
+
$group = 'visible';
231
+
} else {
232
+
$group = 'hidden';
233
+
}
234
+
235
+
$phid = $column->getPHID();
236
+
$display_name = $column->getDisplayName();
237
+
238
+
$column_options[$group][$phid] = $display_name;
239
+
}
240
+
241
+
if ($column_options['hidden']) {
242
+
$column_options = array(
243
+
pht('Visible Columns') => $column_options['visible'],
244
+
pht('Hidden Columns') => $column_options['hidden'],
245
+
);
246
+
} else {
247
+
$column_options = $column_options['visible'];
248
+
}
249
+
222
250
$form->appendControl(
223
-
id(new AphrontFormSelectControl())
224
-
->setName('dstColumnPHID')
225
-
->setLabel(pht('Move to Column'))
226
-
->setValue($dst_column_phid)
227
-
->setOptions(mpull($dst_columns, 'getDisplayName', 'getPHID')));
251
+
id(new AphrontFormSelectControl())
252
+
->setName('dstColumnPHID')
253
+
->setLabel(pht('Move to Column'))
254
+
->setValue($dst_column_phid)
255
+
->setOptions($column_options));
228
256
229
257
$submit = pht('Move Tasks');
230
258