@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up random junk in Conpherence
Summary: Fixes T10781. Re-uses sidenav styles from global space, though a little hacky. Fix crumb border, fix nux experience. Fiddle spacing.
Test Plan:
Use Conpherence as new user, make a room, post some messages.
{F1805658}
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T10781
Differential Revision: https://secure.phabricator.com/D16528
+40
-21
+4
-4
resources/celerity/map.php
+4
-4
resources/celerity/map.php
···
45
45
'rsrc/css/application/config/setup-issue.css' => 'f794cfc3',
46
46
'rsrc/css/application/config/unhandled-exception.css' => '4c96257a',
47
47
'rsrc/css/application/conpherence/durable-column.css' => '86396117',
48
-
'rsrc/css/application/conpherence/menu.css' => '90bdf85c',
49
-
'rsrc/css/application/conpherence/message-pane.css' => '5c7b7b17',
48
+
'rsrc/css/application/conpherence/menu.css' => '26283353',
49
+
'rsrc/css/application/conpherence/message-pane.css' => '8b994132',
50
50
'rsrc/css/application/conpherence/notification.css' => '6cdcc253',
51
51
'rsrc/css/application/conpherence/transaction.css' => '85d0974c',
52
52
'rsrc/css/application/conpherence/update.css' => 'faf6be09',
···
549
549
'config-options-css' => '0ede4c9b',
550
550
'config-page-css' => '8798e14f',
551
551
'conpherence-durable-column-view' => '86396117',
552
-
'conpherence-menu-css' => '90bdf85c',
553
-
'conpherence-message-pane-css' => '5c7b7b17',
552
+
'conpherence-menu-css' => '26283353',
553
+
'conpherence-message-pane-css' => '8b994132',
554
554
'conpherence-notification-css' => '6cdcc253',
555
555
'conpherence-thread-manager' => '01774ab2',
556
556
'conpherence-transaction-css' => '85d0974c',
+7
src/applications/conpherence/controller/ConpherenceController.php
+7
src/applications/conpherence/controller/ConpherenceController.php
···
36
36
37
37
protected function buildConpherenceApplicationCrumbs($is_rooms = false) {
38
38
$crumbs = parent::buildApplicationCrumbs();
39
+
$crumbs->setBorder(true);
40
+
41
+
$crumbs->addAction(
42
+
id(new PHUIListItemView())
43
+
->setName(pht('Search'))
44
+
->setHref($this->getApplicationURI('search/'))
45
+
->setIcon('fa-search'));
39
46
40
47
if ($is_rooms) {
41
48
$crumbs
+7
src/applications/conpherence/view/ConpherenceLayoutView.php
+7
src/applications/conpherence/view/ConpherenceLayoutView.php
···
148
148
javelin_tag(
149
149
'a',
150
150
array(
151
+
'href' => '/conpherence/search/',
152
+
'class' => 'button grey mlr',
153
+
),
154
+
pht('Join a Room')),
155
+
javelin_tag(
156
+
'a',
157
+
array(
151
158
'href' => '/conpherence/new/',
152
159
'class' => 'button grey',
153
160
'sigil' => 'workflow',
+4
-2
src/applications/conpherence/view/ConpherenceMenuItemView.php
+4
-2
src/applications/conpherence/view/ConpherenceMenuItemView.php
···
63
63
}
64
64
65
65
protected function getTagAttributes() {
66
-
$classes = array('conpherence-menu-item-view');
66
+
$classes = array();
67
+
$classes[] = 'conpherence-menu-item-view';
68
+
$classes[] = 'phui-list-item-href';
67
69
return array(
68
-
'class' => $classes,
70
+
'class' => implode(' ', $classes),
69
71
'href' => $this->href,
70
72
);
71
73
}
+3
-5
src/applications/conpherence/view/ConpherenceThreadListView.php
+3
-5
src/applications/conpherence/view/ConpherenceThreadListView.php
···
31
31
32
32
$this->addRoomsToMenu($menu, $this->threads, $policy_objects);
33
33
34
+
$menu = phutil_tag_div('phabricator-side-menu', $menu);
35
+
$menu = phutil_tag_div('phui-basic-nav', $menu);
36
+
34
37
return $menu;
35
38
}
36
39
···
99
102
$header = $this->renderMenuItemHeader(
100
103
pht('Rooms'),
101
104
'conpherence-room-list-header');
102
-
$header->appendChild(
103
-
id(new PHUIIconView())
104
-
->setIcon('fa-search')
105
-
->setHref('/conpherence/search/')
106
-
->setText(pht('Search')));
107
105
$menu->addMenuItem($header);
108
106
109
107
if (empty($rooms)) {
+5
-5
webroot/rsrc/css/application/conpherence/message-pane.css
+5
-5
webroot/rsrc/css/application/conpherence/message-pane.css
···
7
7
.loading .messages-loading-icon,
8
8
.conpherence-layout .conpherence-no-threads {
9
9
position: fixed;
10
-
left: 241px;
11
-
right: 241px;
10
+
left: 240px;
11
+
right: 240px;
12
12
top: 76px;
13
13
bottom: 0px;
14
14
min-width: 300px;
···
52
52
53
53
.conpherence-message-pane .conpherence-messages {
54
54
position: fixed;
55
-
left: 241px;
56
-
right: 241px;
55
+
left: 240px;
56
+
right: 240px;
57
57
top: 78px;
58
58
bottom: 172px;
59
59
overflow-x: hidden;
···
109
109
position: fixed;
110
110
bottom: 0;
111
111
border-top: 1px solid {$thinblueborder};
112
-
left: 241px;
112
+
left: 240px;
113
113
right: 241px;
114
114
}
115
115