@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Mark redirects to php.net from symbols as external
Summary: Fixes T5942. These are external but currently unmarked.
Test Plan: Visited link, got redirected.
Reviewers: btrahan, chad
Reviewed By: chad
Subscribers: epriestley
Maniphest Tasks: T5942
Differential Revision: https://secure.phabricator.com/D10332
+2
+2
src/applications/diffusion/controller/DiffusionSymbolController.php
+2
src/applications/diffusion/controller/DiffusionSymbolController.php
···
57
57
$functions = get_defined_functions();
58
58
if (in_array($this->name, $functions['internal'])) {
59
59
return id(new AphrontRedirectResponse())
60
+
->setIsExternal(true)
60
61
->setURI('http://www.php.net/function.'.$this->name);
61
62
}
62
63
}
···
65
66
interface_exists($this->name, false)) {
66
67
if (id(new ReflectionClass($this->name))->isInternal()) {
67
68
return id(new AphrontRedirectResponse())
69
+
->setIsExternal(true)
68
70
->setURI('http://www.php.net/class.'.$this->name);
69
71
}
70
72
}