@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Prevent web queries from running for more than 30 seconds
Summary:
Ref T10849. This enforces a global 30-second per-query time limit for anything not coming from the CLI.
If we run into another issue with MySQL hanging in the future, this should prevent it from being nearly as bad as it was.
Test Plan:
- Set value to 0, verified the UI threw an exception immediately.
- Set value back to 30, browsed around a bunch of pages.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10849
Differential Revision: https://secure.phabricator.com/D15799
+6
+6
src/infrastructure/storage/lisk/PhabricatorLiskDAO.php
+6
src/infrastructure/storage/lisk/PhabricatorLiskDAO.php
···
75
75
$connection->setReadOnly(true);
76
76
}
77
77
78
+
// Unless this is a script running from the CLI, prevent any query from
79
+
// running for more than 30 seconds. See T10849 for discussion.
80
+
if (php_sapi_name() != 'cli') {
81
+
$connection->setQueryTimeout(30);
82
+
}
83
+
78
84
return $connection;
79
85
}
80
86