@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Catch undefinied title attribute in lightbox
Summary: If the image name in not defined, don't set it. Fixes T6793
Test Plan: View a lightboxed image, no 'undefined' alt tag
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T6793
Differential Revision: https://secure.phabricator.com/D11037
+17
-13
+11
-11
resources/celerity/map.php
+11
-11
resources/celerity/map.php
···
8
8
return array(
9
9
'names' => array(
10
10
'core.pkg.css' => '679c69f6',
11
-
'core.pkg.js' => 'bc72b978',
11
+
'core.pkg.js' => '2d1f7db1',
12
12
'darkconsole.pkg.js' => 'df001cab',
13
13
'differential.pkg.css' => '8af45893',
14
14
'differential.pkg.js' => '42c10e78',
···
462
462
'rsrc/js/core/behavior-keyboard-pager.js' => 'a8da01f0',
463
463
'rsrc/js/core/behavior-keyboard-shortcuts.js' => 'd75709e6',
464
464
'rsrc/js/core/behavior-konami.js' => '5bc2cb21',
465
-
'rsrc/js/core/behavior-lightbox-attachments.js' => '0720f2cf',
465
+
'rsrc/js/core/behavior-lightbox-attachments.js' => 'f8ba29d7',
466
466
'rsrc/js/core/behavior-line-linker.js' => 'f726d506',
467
467
'rsrc/js/core/behavior-more.js' => 'a80d0378',
468
468
'rsrc/js/core/behavior-object-selector.js' => '49b73b36',
···
586
586
'javelin-behavior-icon-composer' => '8ef9ab58',
587
587
'javelin-behavior-konami' => '5bc2cb21',
588
588
'javelin-behavior-launch-icon-composer' => '48086888',
589
-
'javelin-behavior-lightbox-attachments' => '0720f2cf',
589
+
'javelin-behavior-lightbox-attachments' => 'f8ba29d7',
590
590
'javelin-behavior-line-chart' => '22e16ae7',
591
591
'javelin-behavior-load-blame' => '42126667',
592
592
'javelin-behavior-maniphest-batch-editor' => 'f588412e',
···
862
862
'javelin-stratcom',
863
863
'javelin-dom',
864
864
'javelin-vector',
865
-
),
866
-
'0720f2cf' => array(
867
-
'javelin-behavior',
868
-
'javelin-stratcom',
869
-
'javelin-dom',
870
-
'javelin-mask',
871
-
'javelin-util',
872
-
'phabricator-busy',
873
865
),
874
866
'07f199d8' => array(
875
867
'javelin-behavior',
···
1910
1902
'javelin-json',
1911
1903
'javelin-stratcom',
1912
1904
'phabricator-shaped-request',
1905
+
),
1906
+
'f8ba29d7' => array(
1907
+
'javelin-behavior',
1908
+
'javelin-stratcom',
1909
+
'javelin-dom',
1910
+
'javelin-mask',
1911
+
'javelin-util',
1912
+
'phabricator-busy',
1913
1913
),
1914
1914
'f9539603' => array(
1915
1915
'javelin-behavior',
+6
-2
webroot/rsrc/js/core/behavior-lightbox-attachments.js
+6
-2
webroot/rsrc/js/core/behavior-lightbox-attachments.js
···
69
69
);
70
70
}
71
71
72
+
var alt_name = '';
73
+
if (typeof target_data.name != 'undefined') {
74
+
alt_name = target_data.name;
75
+
}
76
+
72
77
var img = JX.$N('img',
73
78
{
74
79
className : 'loading',
75
-
alt : target_data.name,
76
-
title : target_data.name
80
+
alt : alt_name
77
81
}
78
82
);
79
83