@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix invalid CSS overflow value for .phui-oi-name

Summary:
The W3C CSS validator throws `Value Error : overflow normal is not a overflow value : normal`.
`normal` is not a valid value for `overflow`, as browsers currently cannot parse it they fall back to the default `visible`, thus change it to `visible`.
See https://developer.mozilla.org/en-US/docs/Web/CSS/overflow

Test Plan:
Paste `phui-oi-list-view.css` into https://jigsaw.w3.org/css-validator/ and read some CSS docs.

Also, visit a page showing a PHUIObjectItemView, like the /phame/post/ page, and
have a object with a veeeeeery long name, and see absolutely no difference A/B,
both on desktop, medium and small screens.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25921

+4 -4
+3 -3
resources/celerity/map.php
··· 9 9 'names' => array( 10 10 'conpherence.pkg.css' => '3144a5e2', 11 11 'conpherence.pkg.js' => '020aebcf', 12 - 'core.pkg.css' => '3fa476df', 12 + 'core.pkg.css' => '07b1d4b2', 13 13 'core.pkg.js' => 'f58c3c6e', 14 14 'dark-console.pkg.js' => '187792c2', 15 15 'differential.pkg.css' => '91ac6214', ··· 133 133 'rsrc/css/phui/object-item/phui-oi-color.css' => 'b517bfa0', 134 134 'rsrc/css/phui/object-item/phui-oi-drag-ui.css' => 'da15d3dc', 135 135 'rsrc/css/phui/object-item/phui-oi-flush-ui.css' => '490e2e2e', 136 - 'rsrc/css/phui/object-item/phui-oi-list-view.css' => '9275ff55', 136 + 'rsrc/css/phui/object-item/phui-oi-list-view.css' => '2c4e34fa', 137 137 'rsrc/css/phui/object-item/phui-oi-simple-ui.css' => '9b03a61f', 138 138 'rsrc/css/phui/phui-action-list.css' => 'd26ccb62', 139 139 'rsrc/css/phui/phui-action-panel.css' => '6c386cbf', ··· 869 869 'phui-oi-color-css' => 'b517bfa0', 870 870 'phui-oi-drag-ui-css' => 'da15d3dc', 871 871 'phui-oi-flush-ui-css' => '490e2e2e', 872 - 'phui-oi-list-view-css' => '9275ff55', 872 + 'phui-oi-list-view-css' => '2c4e34fa', 873 873 'phui-oi-simple-ui-css' => '9b03a61f', 874 874 'phui-pager-css' => 'd022c7ad', 875 875 'phui-pinboard-view-css' => '1f08f5d8',
+1 -1
webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
··· 95 95 } 96 96 97 97 .device-phone .phui-oi-name { 98 - overflow: normal; 98 + overflow: visible; 99 99 white-space: normal; 100 100 font-weight: bold; 101 101 }