@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Allow tall two-column/curtain headers to be triple-clicked in Firefox
Summary:
Fixes T10905. In Firefox, triple clicking the new headers doesn't select the entire line, so you can't easily copy/paste an entire task title or revision name. It works fine in Safari/Chrome.
This seems to fix that without breaking anything.
Test Plan:
- Viewed headers in Safari, Firefox, Chrome.
- Triple-clicked headers in Safari, Firefox, Chrome.
- Viewed tablet/device layouts in Safari, Firefox, Chrome.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10905
Differential Revision: https://secure.phabricator.com/D15823
+16
-3
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
7
7
*/
8
8
return array(
9
9
'names' => array(
10
-
'core.pkg.css' => '04a95108',
10
+
'core.pkg.css' => 'ede6bf7a',
11
11
'core.pkg.js' => '6972d365',
12
12
'darkconsole.pkg.js' => 'e7393ebb',
13
13
'differential.pkg.css' => '7ba78475',
···
136
136
'rsrc/css/phui/phui-form-view.css' => '6a51768e',
137
137
'rsrc/css/phui/phui-form.css' => 'aac1d51d',
138
138
'rsrc/css/phui/phui-head-thing.css' => 'fd311e5f',
139
-
'rsrc/css/phui/phui-header-view.css' => '230254d3',
139
+
'rsrc/css/phui/phui-header-view.css' => '9961e480',
140
140
'rsrc/css/phui/phui-hovercard.css' => 'de1a2119',
141
141
'rsrc/css/phui/phui-icon-set-selector.css' => '1ab67aad',
142
142
'rsrc/css/phui/phui-icon.css' => '3f33ab57',
···
829
829
'phui-form-css' => 'aac1d51d',
830
830
'phui-form-view-css' => '6a51768e',
831
831
'phui-head-thing-view-css' => 'fd311e5f',
832
-
'phui-header-view-css' => '230254d3',
832
+
'phui-header-view-css' => '9961e480',
833
833
'phui-hovercard' => '1bd28176',
834
834
'phui-hovercard-view-css' => 'de1a2119',
835
835
'phui-icon-set-selector-css' => '1ab67aad',
+9
src/view/phui/PHUIHeaderView.php
+9
src/view/phui/PHUIHeaderView.php
···
316
316
$header_content);
317
317
}
318
318
319
+
// This wrapper element allows titles to be triple-clicked to select them
320
+
// in Firefox. See T10905 for discussion.
321
+
$header_content = phutil_tag(
322
+
'span',
323
+
array(
324
+
'class' => 'phui-header-content',
325
+
),
326
+
$header_content);
327
+
319
328
$left[] = phutil_tag(
320
329
'span',
321
330
array(
+4
webroot/rsrc/css/phui/phui-header-view.css
+4
webroot/rsrc/css/phui/phui-header-view.css