@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
PhabricatorManiphestConfigOptions: Do not loop over an empty array
Summary: Comment a foreach loop to avoid "Empty array passed to foreach" output in static code analysis.
Test Plan: Run static code analysis.
Reviewers: O1 Blessed Committers, mainframe98
Reviewed By: O1 Blessed Committers, mainframe98
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D26455
+6
-6
+6
-6
src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php
+6
-6
src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php
···
248
248
$status_example = $json->encodeFormatted($status_example);
249
249
250
250
// This is intentionally blank for now, until we can move more Maniphest
251
-
// logic to custom fields.
251
+
// logic to custom fields. Once done, enable the foreach loop below.
252
252
$default_fields = array();
253
253
254
-
foreach ($default_fields as $key => $enabled) {
255
-
$default_fields[$key] = array(
256
-
'disabled' => !$enabled,
257
-
);
258
-
}
254
+
// foreach ($default_fields as $key => $enabled) {
255
+
// $default_fields[$key] = array(
256
+
// 'disabled' => !$enabled,
257
+
// );
258
+
// }
259
259
260
260
$custom_field_type = 'custom:PhabricatorCustomFieldConfigOptionType';
261
261