@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't fatal on image macro list if a file has been deleted
Summary:
We added the ability to delete files a while ago, but this interface isn't happy about it.
I still render the macro so you can see/delete it, e.g.
Test Plan: Viewed a deleted macro page, got a page instead of an error. Also verified that the actual remarkup part doesn't have issues.
Reviewers: btrahan, vrana, jungejason
Reviewed By: jungejason
CC: aran
Differential Revision: https://secure.phabricator.com/D2328
+4
-3
+4
-3
src/applications/files/controller/macrolist/PhabricatorFileMacroListController.php
+4
-3
src/applications/files/controller/macrolist/PhabricatorFileMacroListController.php
···
65
65
$rows = array();
66
66
foreach ($macros as $macro) {
67
67
$file_phid = $macro->getFilePHID();
68
-
$file = $files_map[$file_phid];
68
+
$file = idx($files_map, $file_phid);
69
+
69
70
$author_link = isset($author_phids[$file_phid])
70
71
? $handles[$author_phids[$file_phid]]->renderLink()
71
72
: null;
···
82
83
phutil_render_tag(
83
84
'a',
84
85
array(
85
-
'href' => $file->getBestURI(),
86
+
'href' => $file ? $file->getBestURI() : null,
86
87
'target' => '_blank',
87
88
),
88
89
phutil_render_tag(
89
90
'img',
90
91
array(
91
-
'src' => $file->getBestURI(),
92
+
'src' => $file ? $file->getBestURI() : null,
92
93
))),
93
94
javelin_render_tag(
94
95
'a',