@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Define `diff` as a local variable

Summary: This should be a local variable, not a global variable. This silences a few JSHint warnings.

Test Plan: `arc lint`

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11070

authored by

Joshua Spence and committed by
epriestley
07dbd520 db563426

+16 -16
+15 -15
resources/celerity/map.php
··· 11 11 'core.pkg.js' => '44aac665', 12 12 'darkconsole.pkg.js' => 'd326843f', 13 13 'differential.pkg.css' => '8af45893', 14 - 'differential.pkg.js' => '42c10e78', 14 + 'differential.pkg.js' => 'dad3622f', 15 15 'diffusion.pkg.css' => '591664fa', 16 16 'diffusion.pkg.js' => 'bfc0737b', 17 17 'maniphest.pkg.css' => 'e34dfbec', ··· 359 359 'rsrc/js/application/differential/behavior-comment-jump.js' => '4fdb476d', 360 360 'rsrc/js/application/differential/behavior-comment-preview.js' => '6932def3', 361 361 'rsrc/js/application/differential/behavior-diff-radios.js' => 'e1ff79b1', 362 - 'rsrc/js/application/differential/behavior-dropdown-menus.js' => '710f209e', 362 + 'rsrc/js/application/differential/behavior-dropdown-menus.js' => '3bc14668', 363 363 'rsrc/js/application/differential/behavior-edit-inline-comments.js' => '00861799', 364 364 'rsrc/js/application/differential/behavior-keyboard-nav.js' => '2c426492', 365 365 'rsrc/js/application/differential/behavior-populate.js' => 'bdb3e4d0', ··· 562 562 'javelin-behavior-differential-add-reviewers-and-ccs' => 'e10f8e18', 563 563 'javelin-behavior-differential-comment-jump' => '4fdb476d', 564 564 'javelin-behavior-differential-diff-radios' => 'e1ff79b1', 565 - 'javelin-behavior-differential-dropdown-menus' => '710f209e', 565 + 'javelin-behavior-differential-dropdown-menus' => '3bc14668', 566 566 'javelin-behavior-differential-edit-inline-comments' => '00861799', 567 567 'javelin-behavior-differential-feedback-preview' => '6932def3', 568 568 'javelin-behavior-differential-keyboard-navigation' => '2c426492', ··· 1003 1003 'javelin-dom', 1004 1004 'javelin-magical-init', 1005 1005 ), 1006 + '3bc14668' => array( 1007 + 'javelin-behavior', 1008 + 'javelin-dom', 1009 + 'javelin-util', 1010 + 'javelin-stratcom', 1011 + 'javelin-workflow', 1012 + 'phuix-dropdown-menu', 1013 + 'phuix-action-list-view', 1014 + 'phuix-action-view', 1015 + 'phabricator-phtize', 1016 + 'changeset-view-manager', 1017 + ), 1006 1018 '3d51a746' => array( 1007 1019 'javelin-behavior', 1008 1020 'javelin-dom', ··· 1211 1223 'javelin-install', 1212 1224 'javelin-util', 1213 1225 'javelin-stratcom', 1214 - ), 1215 - '710f209e' => array( 1216 - 'javelin-behavior', 1217 - 'javelin-dom', 1218 - 'javelin-util', 1219 - 'javelin-stratcom', 1220 - 'javelin-workflow', 1221 - 'phuix-dropdown-menu', 1222 - 'phuix-action-list-view', 1223 - 'phuix-action-view', 1224 - 'phabricator-phtize', 1225 - 'changeset-view-manager', 1226 1226 ), 1227 1227 '724b1247' => array( 1228 1228 'javelin-behavior',
+1 -1
webroot/rsrc/js/application/differential/behavior-dropdown-menus.js
··· 229 229 'More than one node with sigil "differential-diff" was found in "'+ 230 230 data.containerID+'."'); 231 231 } else if (diffs.length == 1) { 232 - diff = diffs[0]; 232 + var diff = diffs[0]; 233 233 visible_item.setDisabled(false); 234 234 if (JX.Stratcom.getData(diff).hidden) { 235 235 visible_item