@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
UIExample: Use PHUIInfoView instead of custom notice element
Summary:
This is dark mode compatible, removes custom on-off styles and
preserves the consistent look-and-feel of Phorge.
Refs T15056
Test Plan: Visit http://phorge.localhost/uiexample/view/PhabricatorPagerUIExample/ and scroll down to the pager.
Reviewers: O1 Blessed Committers, aklapper
Reviewed By: O1 Blessed Committers, aklapper
Subscribers: aklapper, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T15056
Differential Revision: https://we.phorge.it/D26150
+26
-28
+2
-2
resources/celerity/map.php
+2
-2
resources/celerity/map.php
···
102
102
'rsrc/css/application/search/search-results.css' => '9ea70ace',
103
103
'rsrc/css/application/slowvote/slowvote.css' => '0f219c39',
104
104
'rsrc/css/application/tokens/tokens.css' => 'cba3965f',
105
-
'rsrc/css/application/uiexample/example.css' => '549e220b',
105
+
'rsrc/css/application/uiexample/example.css' => '69d6682f',
106
106
'rsrc/css/core/core.css' => '83d97073',
107
107
'rsrc/css/core/remarkup.css' => '6ab3c4aa',
108
108
'rsrc/css/core/syntax.css' => '548567f6',
···
783
783
'phabricator-textareautils' => 'f340a484',
784
784
'phabricator-title' => '43bc9360',
785
785
'phabricator-tooltip' => '83754533',
786
-
'phabricator-ui-example-css' => '549e220b',
786
+
'phabricator-ui-example-css' => '69d6682f',
787
787
'phabricator-zindex-css' => '56fbe5ba',
788
788
'phame-css' => '209125c7',
789
789
'pholio-css' => '87870afb',
+24
-15
src/applications/uiexample/examples/PhabricatorPagerUIExample.php
+24
-15
src/applications/uiexample/examples/PhabricatorPagerUIExample.php
···
36
36
$panel->setHeaderText(pht('Example'));
37
37
$panel->appendChild($table);
38
38
39
-
$panel->appendChild(hsprintf(
40
-
'<p class="phabricator-ui-example-note">%s</p>',
41
-
pht(
42
-
'Use %s to render a pager element.',
43
-
phutil_tag('tt', array(), 'PHUIPagerView'))));
39
+
$panel->appendChild(
40
+
id(new PHUIInfoView())
41
+
->setSeverity(PHUIInfoView::SEVERITY_NOTICE)
42
+
->setErrors(array(
43
+
pht(
44
+
'Use %s to render a pager element.',
45
+
phutil_tag('tt', array(), 'PHUIPagerView')),
46
+
)));
44
47
45
48
$pager = new PHUIPagerView();
46
49
$pager->setPageSize($page_size);
···
49
52
$pager->setURI($request->getRequestURI(), 'offset');
50
53
$panel->appendChild($pager);
51
54
52
-
$panel->appendChild(hsprintf(
53
-
'<p class="phabricator-ui-example-note">%s</p>',
54
-
pht('You can show more or fewer pages of surrounding context.')));
55
+
$panel->appendChild(
56
+
id(new PHUIInfoView())
57
+
->setSeverity(PHUIInfoView::SEVERITY_NOTICE)
58
+
->setErrors(array(
59
+
pht('You can show more or fewer pages of surrounding context.'),
60
+
)));
55
61
56
62
$many_pages_pager = new PHUIPagerView();
57
63
$many_pages_pager->setPageSize($page_size);
···
61
67
$many_pages_pager->setSurroundingPages(7);
62
68
$panel->appendChild($many_pages_pager);
63
69
64
-
$panel->appendChild(hsprintf(
65
-
'<p class="phabricator-ui-example-note">%s</p>',
66
-
pht(
67
-
'When it is prohibitively expensive or complex to attain a complete '.
68
-
'count of the items, you can select one extra item and set '.
69
-
'%s if it exists, creating an inexact pager.',
70
-
phutil_tag('tt', array(), 'hasMorePages(true)'))));
70
+
$panel->appendChild(
71
+
id(new PHUIInfoView())
72
+
->setSeverity(PHUIInfoView::SEVERITY_NOTICE)
73
+
->setErrors(array(
74
+
pht(
75
+
'When it is prohibitively expensive or complex to attain a '.
76
+
'complete count of the items, you can select one extra item and '.
77
+
'set %s if it exists, creating an inexact pager.',
78
+
phutil_tag('tt', array(), 'hasMorePages(true)')),
79
+
)));
71
80
72
81
$inexact_pager = new PHUIPagerView();
73
82
$inexact_pager->setPageSize($page_size);
-11
webroot/rsrc/css/application/uiexample/example.css
-11
webroot/rsrc/css/application/uiexample/example.css
···
2
2
* @provides phabricator-ui-example-css
3
3
*/
4
4
5
-
.phabricator-ui-example-note {
6
-
padding: .5em;
7
-
margin: 2em 1em 0.5em;
8
-
background: #ffffdd;
9
-
border: 1px solid #f5e178;
10
-
}
11
-
12
-
.phabricator-ui-example-note tt {
13
-
font-weight: bold;
14
-
}
15
-
16
5
.phui-example-icon-name {
17
6
display: inline-block;
18
7
width: 180px;