@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix mouse access to Workboard scrollbars
Summary: Fixes T7075. The invisible "fancy" scrollbar was covering these; hide it more aggressively.
Test Plan:
- Scrollbars on Workboards can now be interacted with directly.
- Normal scrollable and unscrollable pages work as expected.
- Resized some windows.
Reviewers: btrahan, chad
Reviewed By: chad
Subscribers: epriestley
Maniphest Tasks: T7075
Differential Revision: https://secure.phabricator.com/D11560
+21
-13
+8
-8
resources/celerity/map.php
+8
-8
resources/celerity/map.php
···
199
199
'rsrc/externals/javelin/lib/Resource.js' => '44959b73',
200
200
'rsrc/externals/javelin/lib/Routable.js' => 'b3e7d692',
201
201
'rsrc/externals/javelin/lib/Router.js' => '29274e2b',
202
-
'rsrc/externals/javelin/lib/Scrollbar.js' => 'ef2ec0c6',
202
+
'rsrc/externals/javelin/lib/Scrollbar.js' => '5b2f5a08',
203
203
'rsrc/externals/javelin/lib/URI.js' => '6eff08aa',
204
204
'rsrc/externals/javelin/lib/Vector.js' => '2caa8fb8',
205
205
'rsrc/externals/javelin/lib/WebSocket.js' => '3f840822',
···
672
672
'javelin-resource' => '44959b73',
673
673
'javelin-routable' => 'b3e7d692',
674
674
'javelin-router' => '29274e2b',
675
-
'javelin-scrollbar' => 'ef2ec0c6',
675
+
'javelin-scrollbar' => '5b2f5a08',
676
676
'javelin-stratcom' => '6c53634d',
677
677
'javelin-tokenizer' => '7644823e',
678
678
'javelin-typeahead' => '70baed2f',
···
1186
1186
'javelin-vector',
1187
1187
'javelin-dom',
1188
1188
),
1189
+
'5b2f5a08' => array(
1190
+
'javelin-install',
1191
+
'javelin-dom',
1192
+
'javelin-stratcom',
1193
+
'javelin-vector',
1194
+
),
1189
1195
'5bc2cb21' => array(
1190
1196
'javelin-behavior',
1191
1197
'javelin-stratcom',
···
1862
1868
'javelin-aphlict',
1863
1869
'phabricator-phtize',
1864
1870
'javelin-dom',
1865
-
),
1866
-
'ef2ec0c6' => array(
1867
-
'javelin-install',
1868
-
'javelin-dom',
1869
-
'javelin-stratcom',
1870
-
'javelin-vector',
1871
1871
),
1872
1872
'efe49472' => array(
1873
1873
'javelin-install',
+13
-5
webroot/rsrc/externals/javelin/lib/Scrollbar.js
+13
-5
webroot/rsrc/externals/javelin/lib/Scrollbar.js
···
308
308
* Figure out the correct size and offset of the scrollbar handle.
309
309
*/
310
310
_resizeBar: function() {
311
+
// We're hiding and showing the bar itself, not just the handle, because
312
+
// pages that contain other panels may have scrollbars underneath the
313
+
// bar. If we don't hide the bar, it ends up eating clicks targeting
314
+
// these panels.
315
+
316
+
// Because the bar may be hidden, we can't measure it. Measure the
317
+
// viewport instead.
318
+
311
319
var cdim = JX.Vector.getDim(this._content);
312
320
var spos = JX.Vector.getAggregateScrollForNode(this._viewport);
313
-
var bdim = JX.Vector.getDim(this._bar);
321
+
var vdim = JX.Vector.getDim(this._viewport);
314
322
315
-
var ratio = bdim.y / cdim.y;
323
+
var ratio = vdim.y / cdim.y;
316
324
317
325
var offset = Math.round(ratio * spos.y) + 2;
318
-
var size = Math.floor(ratio * (bdim.y - 2)) - 2;
326
+
var size = Math.floor(ratio * (vdim.y - 2)) - 2;
319
327
320
328
if (size < cdim.y) {
321
329
this._handle.style.top = offset + 'px';
322
330
this._handle.style.height = size + 'px';
323
331
324
-
JX.DOM.show(this._handle);
332
+
JX.DOM.show(this._bar);
325
333
} else {
326
-
JX.DOM.hide(this._handle);
334
+
JX.DOM.hide(this._bar);
327
335
}
328
336
},
329
337