@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
fluid diff -- more table silliness
Summary: inline comments eat up all 3 tds and no code coverage should be shown.
Test Plan: verified in FIREFOX that inline comments looked good
Reviewers: vrana, epriestley
Reviewed By: epriestley
CC: aran, Korvin
Maniphest Tasks: T2005
Differential Revision: https://secure.phabricator.com/D4115
+2
-4
+2
-4
src/applications/differential/parser/DifferentialChangesetParser.php
+2
-4
src/applications/differential/parser/DifferentialChangesetParser.php
···
1650
1650
'<th />'.
1651
1651
'<td class="left">'.$xhp.'</td>'.
1652
1652
'<th />'.
1653
-
'<td colspan="2">'.$new.'</td>'.
1654
-
'<td class="cov" />'.
1653
+
'<td colspan="3" class="right3">'.$new.'</td>'.
1655
1654
'</tr>';
1656
1655
}
1657
1656
}
···
1663
1662
'<th />'.
1664
1663
'<td class="left" />'.
1665
1664
'<th />'.
1666
-
'<td colspan="2">'.$xhp.'</td>'.
1667
-
'<td class="cov" />'.
1665
+
'<td colspan="3" class="right3">'.$xhp.'</td>'.
1668
1666
'</tr>';
1669
1667
}
1670
1668
}