@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Enable query activediff timestamp
Summary: people want to get the info about how long the revision has been active since the last time the authoer ran 'arc diff'.
Test Plan: call it from conduit console
Reviewers: vrana, epriestley
Reviewed By: epriestley
CC: Girish, aran, epriestley
Differential Revision: https://secure.phabricator.com/D2885
+16
-7
+16
-7
src/applications/differential/query/DifferentialRevisionQuery.php
+16
-7
src/applications/differential/query/DifferentialRevisionQuery.php
···
34
34
35
35
private $pathIDs = array();
36
36
37
-
private $status = 'status-any';
38
-
const STATUS_ANY = 'status-any';
39
-
const STATUS_OPEN = 'status-open';
40
-
const STATUS_ACCEPTED = 'status-accepted';
41
-
const STATUS_CLOSED = 'status-closed'; // NOTE: Same as 'committed'.
42
-
const STATUS_COMMITTED = 'status-committed'; // TODO: Remove.
43
-
const STATUS_ABANDONED = 'status-abandoned';
37
+
private $status = 'status-any';
38
+
const STATUS_ANY = 'status-any';
39
+
const STATUS_OPEN = 'status-open';
40
+
const STATUS_ACCEPTED = 'status-accepted';
41
+
const STATUS_NEEDS_REVIEW = 'status-needs-review';
42
+
const STATUS_CLOSED = 'status-closed'; // NOTE: Same as 'committed'.
43
+
const STATUS_COMMITTED = 'status-committed'; // TODO: Remove.
44
+
const STATUS_ABANDONED = 'status-abandoned';
44
45
45
46
private $authors = array();
46
47
private $draftAuthors = array();
···
690
691
ArcanistDifferentialRevisionStatus::NEEDS_REVIEW,
691
692
ArcanistDifferentialRevisionStatus::NEEDS_REVISION,
692
693
ArcanistDifferentialRevisionStatus::ACCEPTED,
694
+
));
695
+
break;
696
+
case self::STATUS_NEEDS_REVIEW:
697
+
$where[] = qsprintf(
698
+
$conn_r,
699
+
'status IN (%Ld)',
700
+
array(
701
+
ArcanistDifferentialRevisionStatus::NEEDS_REVIEW,
693
702
));
694
703
break;
695
704
case self::STATUS_ACCEPTED: