@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "strlen(null)" exceptions trying to authenticate via custom OAuth provider

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

This change also replaces two other `strlen()` calls, only based on //reading// the code but not based on triggering exceptions.

```
EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(), ava(), phorge(), wmf-ext-misc()
#0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/applications/auth/adapter/PhutilOAuth1AuthAdapter.php:121]
```

```
EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(), ava(), phorge(), wmf-ext-misc()
#0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/applications/auth/adapter/PhutilOAuth1AuthAdapter.php:125]
```

Closes T15588

Test Plan: Go to `/auth/login/mediawiki:whatever/` and at least see no `strlen()` errors anymore (while further issues remain). See T15588 for details.

Reviewers: O1 Blessed Committers, Matthew

Reviewed By: O1 Blessed Committers, Matthew

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15588

Differential Revision: https://we.phorge.it/D25373

+4 -4
+4 -4
src/applications/auth/adapter/PhutilOAuth1AuthAdapter.php
··· 104 104 ->setSignatureMethod($this->getSignatureMethod()); 105 105 106 106 $consumer_key = $this->getConsumerKey(); 107 - if (strlen($consumer_key)) { 107 + if (phutil_nonempty_string($consumer_key)) { 108 108 $future->setConsumerKey($consumer_key); 109 109 } else { 110 110 throw new Exception( ··· 118 118 $future->setConsumerSecret($consumer_secret); 119 119 } 120 120 121 - if (strlen($this->getToken())) { 121 + if (phutil_nonempty_string($this->getToken())) { 122 122 $future->setToken($this->getToken()); 123 123 } 124 124 125 - if (strlen($this->getTokenSecret())) { 125 + if (phutil_nonempty_string($this->getTokenSecret())) { 126 126 $future->setTokenSecret($this->getTokenSecret()); 127 127 } 128 128 ··· 137 137 $request_token_uri = $this->getRequestTokenURI(); 138 138 139 139 $future = $this->newOAuth1Future($request_token_uri); 140 - if (strlen($this->getCallbackURI())) { 140 + if (phutil_nonempty_string($this->getCallbackURI())) { 141 141 $future->setCallbackURI($this->getCallbackURI()); 142 142 } 143 143