@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Herald Transcripts: Use μs instead of us for microseconds
Summary:
Use Unicode abbreviation `μs` for microseconds instead of ASCII `us` which made me wonder for a while what that is.
`mb_chr` is available since PHP 7.2.0 (which Phorge requires). Entering μ directly makes lint bark about "Bad Charset".
Test Plan:
Go to http://phorge.localhost/herald/transcript/1/profile/ and look at values in the "Cost" column.
Works with PHP 8.3; no clue which prehistoric PHP versions may have problems.
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D25942
+1
-1
+1
-1
src/applications/herald/controller/HeraldTranscriptController.php
+1
-1
src/applications/herald/controller/HeraldTranscriptController.php
···
613
613
foreach ($profile as $frame) {
614
614
$cost = $frame['elapsed'];
615
615
$cost = 1000000 * $cost;
616
-
$cost = pht('%sus', new PhutilNumber($cost));
616
+
$cost = pht('%s%ss', new PhutilNumber($cost), mb_chr(956, 'UTF-8'));
617
617
618
618
$type = $frame['type'];
619
619
switch ($type) {