@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add title to PHUIObjectItemView's name for hover display
Summary: This adds back the title to the header link and scans through the codebase for instances where
Test Plan: Tested as many ObjectItemLists as I could find (each app homepage), there may be outliers, but can resolve those individually.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D10961
+5
-4
+2
-3
src/applications/differential/view/DifferentialRevisionListView.php
+2
-3
src/applications/differential/view/DifferentialRevisionListView.php
···
121
121
}
122
122
123
123
$item->setObjectName('D'.$revision->getID());
124
-
$item->setHeader(phutil_tag('a',
125
-
array('href' => '/D'.$revision->getID()),
126
-
$revision->getTitle()));
124
+
$item->setHeader($revision->getTitle());
125
+
$item->setHref('/D'.$revision->getID());
127
126
128
127
if (isset($icons['draft'])) {
129
128
$draft = id(new PHUIIconView())
+2
-1
src/applications/flag/query/PhabricatorFlagSearchEngine.php
+2
-1
src/applications/flag/query/PhabricatorFlagSearchEngine.php
···
149
149
150
150
$item = id(new PHUIObjectItemView())
151
151
->addHeadIcon($flag_icon)
152
-
->setHeader($flag->getHandle()->renderLink());
152
+
->setHeader($flag->getHandle()->getFullName())
153
+
->setHref($flag->getHandle()->getURI());
153
154
154
155
$item->addAction(
155
156
id(new PHUIListItemView())