@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Minor, touch up Exception rendering
Summary: Cleans up spacing, hides footer if nothing present, uses common colors.
Test Plan:
Write some typical for a designer code.
{F309840}
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D11824
+29
-35
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
7
7
*/
8
8
return array(
9
9
'names' => array(
10
-
'core.pkg.css' => '8edbf4c0',
10
+
'core.pkg.css' => '048d109b',
11
11
'core.pkg.js' => '23d653bb',
12
12
'darkconsole.pkg.js' => '8ab24e01',
13
13
'differential.pkg.css' => '380f07e5',
···
19
19
'rsrc/css/aphront/aphront-bars.css' => '231ac33c',
20
20
'rsrc/css/aphront/context-bar.css' => '1c3b0529',
21
21
'rsrc/css/aphront/dark-console.css' => '6378ef3d',
22
-
'rsrc/css/aphront/dialog-view.css' => '52dcd4c6',
22
+
'rsrc/css/aphront/dialog-view.css' => 'd2e76b88',
23
23
'rsrc/css/aphront/lightbox-attachment.css' => '7acac05d',
24
24
'rsrc/css/aphront/list-filter-view.css' => '2ae43867',
25
25
'rsrc/css/aphront/multi-column.css' => '41a848c0',
···
501
501
'aphront-bars' => '231ac33c',
502
502
'aphront-contextbar-view-css' => '1c3b0529',
503
503
'aphront-dark-console-css' => '6378ef3d',
504
-
'aphront-dialog-view-css' => '52dcd4c6',
504
+
'aphront-dialog-view-css' => 'd2e76b88',
505
505
'aphront-list-filter-view-css' => '2ae43867',
506
506
'aphront-multi-column-view-css' => '41a848c0',
507
507
'aphront-pager-view-css' => '2e3539af',
+14
-9
src/view/AphrontDialogView.php
+14
-9
src/view/AphrontDialogView.php
···
311
311
$this->footers);
312
312
}
313
313
314
+
$tail = null;
315
+
if ($buttons || $footer) {
316
+
$tail = phutil_tag(
317
+
'div',
318
+
array(
319
+
'class' => 'aphront-dialog-tail grouped',
320
+
),
321
+
array(
322
+
$buttons,
323
+
$footer,
324
+
));
325
+
}
326
+
314
327
$content = array(
315
328
phutil_tag(
316
329
'div',
···
323
336
'class' => 'aphront-dialog-body grouped',
324
337
),
325
338
$children),
326
-
phutil_tag(
327
-
'div',
328
-
array(
329
-
'class' => 'aphront-dialog-tail grouped',
330
-
),
331
-
array(
332
-
$buttons,
333
-
$footer,
334
-
)),
339
+
$tail,
335
340
);
336
341
337
342
if ($this->renderAsForm) {
+7
-11
src/view/widget/AphrontStackTraceView.php
+7
-11
src/view/widget/AphrontStackTraceView.php
···
92
92
$table = new AphrontTableView($rows);
93
93
$table->setHeaders(
94
94
array(
95
-
'Depth',
96
-
'Library',
97
-
'File',
98
-
'Where',
95
+
pht('Depth'),
96
+
pht('Library'),
97
+
pht('File'),
98
+
pht('Where'),
99
99
));
100
100
$table->setColumnClasses(
101
101
array(
···
107
107
108
108
return phutil_tag(
109
109
'div',
110
-
array('class' => 'exception-trace'),
111
110
array(
112
-
phutil_tag(
113
-
'div',
114
-
array('class' => 'exception-trace-header'),
115
-
pht('Stack Trace')),
116
-
$table->render(),
117
-
));
111
+
'class' => 'exception-trace',
112
+
),
113
+
$table->render());
118
114
}
119
115
120
116
}
+5
-12
webroot/rsrc/css/aphront/dialog-view.css
+5
-12
webroot/rsrc/css/aphront/dialog-view.css
···
55
55
border: none;
56
56
background: {$lightgreybackground};
57
57
padding: 8px 16px;
58
-
border-top: 1px solid #d4dadf;
58
+
border-top: 1px solid {$thinblueborder};
59
59
}
60
60
61
61
.aphront-dialog-foot {
···
95
95
96
96
.aphront-exception-dialog .exception-message {
97
97
font-size: 14px;
98
-
background: #efefef;
99
-
padding: 1em;
98
+
background: {$sh-yellowbackground};
99
+
border: 1px solid {$sh-yellowborder};
100
+
padding: 12px;
100
101
white-space: pre-wrap;
101
102
}
102
103
103
104
.aphront-exception-dialog .exception-trace {
104
-
margin-top: 15px;
105
-
}
106
-
107
-
.aphront-exception-dialog .exception-trace-header {
108
-
font-size: 11px;
109
-
color: {$greytext};
110
-
border-bottom: 1px solid #aaaaaa;
111
-
padding-bottom: .5em;
112
-
margin-bottom: .5em;
105
+
margin-top: 16px;
113
106
}
114
107
115
108
.aphront-access-dialog {