@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up Macro view page
Summary: Sets a header icon, makes "Details" not show if empty, simplifies title.
Test Plan: Review a few Macro pages for changes with and without audio.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D15406
+7
-2
+7
-2
src/applications/macro/controller/PhabricatorMacroViewController.php
+7
-2
src/applications/macro/controller/PhabricatorMacroViewController.php
···
40
40
$header = id(new PHUIHeaderView())
41
41
->setUser($viewer)
42
42
->setPolicyObject($macro)
43
-
->setHeader($title_long);
43
+
->setHeader($macro->getName())
44
+
->setHeaderIcon('fa-file-image-o');
44
45
45
46
if (!$macro->getIsDisabled()) {
46
47
$header->setStatus('fa-check', 'bluegrey', pht('Active'));
···
177
178
$viewer->renderHandle($audio_phid));
178
179
}
179
180
180
-
return $view;
181
+
if ($view->hasAnyProperties()) {
182
+
return $view;
183
+
}
184
+
185
+
return null;
181
186
}
182
187
183
188
private function buildFileView(