@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix "add more metadata" fatal in Pholio
Summary: Ref T13332. This fix isn't terribly satisfying, but resolves the issue: this behavior may attempt to build HTML blocks with metadata after Javascript footer rendering has started. Use `hsprintf()` to flatten the markup earlier.
Test Plan: Put a `T123` reference in the description of a Pholio image, then loaded a mock.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13332
Differential Revision: https://secure.phabricator.com/D20647
+1
-1
+1
-1
src/applications/pholio/view/PholioMockImagesView.php
+1
-1
src/applications/pholio/view/PholioMockImagesView.php
···
103
103
'width' => $x,
104
104
'height' => $y,
105
105
'title' => $image->getName(),
106
-
'descriptionMarkup' => $description,
106
+
'descriptionMarkup' => hsprintf('%s', $description),
107
107
'isObsolete' => (bool)$image->getIsObsolete(),
108
108
'isImage' => $file->isViewableImage(),
109
109
'isViewable' => $file->isViewableInBrowser(),