@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Merge branch 'phutil_tag'
+16
-8
+9
-3
src/applications/differential/parser/DifferentialChangesetParser.php
+9
-3
src/applications/differential/parser/DifferentialChangesetParser.php
···
63
63
return $this->disableCache;
64
64
}
65
65
66
-
const CACHE_VERSION = 10;
66
+
const CACHE_VERSION = 11;
67
67
const CACHE_MAX_SIZE = 8e6;
68
68
69
69
const ATTR_GENERATED = 'attr:generated';
···
270
270
return false;
271
271
}
272
272
273
-
$data = json_decode($data['cache'], true);
273
+
if ($data['cache'][0] == '{') {
274
+
// This is likely an old-style JSON cache which we will not be able to
275
+
// deserialize.
276
+
return false;
277
+
}
278
+
279
+
$data = unserialize($data['cache']);
274
280
if (!is_array($data) || !$data) {
275
281
return false;
276
282
}
···
340
346
break;
341
347
}
342
348
}
343
-
$cache = json_encode($cache);
349
+
$cache = serialize($cache);
344
350
345
351
// We don't want to waste too much space by a single changeset.
346
352
if (strlen($cache) > self::CACHE_MAX_SIZE) {
+1
-1
src/applications/differential/render/DifferentialChangesetHTMLRenderer.php
+1
-1
src/applications/differential/render/DifferentialChangesetHTMLRenderer.php
+6
-4
src/applications/project/controller/PhabricatorProjectProfileEditController.php
+6
-4
src/applications/project/controller/PhabricatorProjectProfileEditController.php
···
168
168
->setLabel(pht('Blurb'))
169
169
->setName('blurb')
170
170
->setValue($profile->getBlurb()))
171
-
->appendChild('<p class="aphront-form-instructions">'.
172
-
pht('NOTE: Policy settings are not yet fully implemented. '.
173
-
'Some interfaces still ignore these settings, '.
174
-
'particularly "Visible To".').'</p>')
171
+
->appendChild(hsprintf(
172
+
'<p class="aphront-form-instructions">%s</p>',
173
+
pht(
174
+
'NOTE: Policy settings are not yet fully implemented. '.
175
+
'Some interfaces still ignore these settings, '.
176
+
'particularly "Visible To".')))
175
177
->appendChild(
176
178
id(new AphrontFormPolicyControl())
177
179
->setUser($user)